X-Spam-Check-By: sourceware.org
Date: Tue, 6 Dec 2005 22:01:45 -0500 (EST)
From: Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH] cygcheck bug when listing services
In-Reply-To: <20051207014747.GC15641@trixie.casa.cgf.cx>
Message-ID: <Pine.GSO.4.63.0512062157240.35@slinky.cs.nyu.edu>
References: <5a97ceb0512042223i404ebffeuff5546e2345df965 AT mail DOT gmail DOT com>  <Pine DOT GSO DOT 4 DOT 63 DOT 0512050924150 DOT 13495 AT slinky DOT cs DOT nyu DOT edu> <20051207000050 DOT GB5452 AT efn DOT org>  <Pine DOT GSO DOT 4 DOT 63 DOT 0512062038150 DOT 35 AT slinky DOT cs DOT nyu DOT edu> <20051207014747 DOT GC15641 AT trixie DOT casa DOT cgf DOT cx>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Tue, 6 Dec 2005, Christopher Faylor wrote:

> On Tue, Dec 06, 2005 at 08:41:24PM -0500, Igor Pechtchanski wrote:
> >On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote:
> >[snip]
> >> That needs a comment in the code.
> >
> >Fair enough:
> >[snip]
> >+      /* Add two nulls to avoid confusing strtok() when the trailing separator
> >+         is missing */
>
> How about a testcase which shows that the MSVCRT strtok needs two
> trailing NUL bytes to work around problems when there is no trailing
> separator?  I would find that much more interesting than a comment which
> simply asserts that behavior.

Fair enough.  The double-null issue was a red herring, apparently -- a
simple recompile fixed the problem.  In fact, the cygcheck from the latest
snapshot doesn't exhibit this behavior.  Patch withdrawn.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/