Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com From: Jim Meyering To: Paul Eggert Cc: ericblake AT comcast DOT net (Eric Blake), cygwin AT cygwin DOT com, bug-coreutils AT gnu DOT org Subject: Re: mkdir -p and EROFS In-Reply-To: <87r7aqqvie.fsf@penguin.cs.ucla.edu> (Paul Eggert's message of "Wed, 12 Oct 2005 14:24:09 -0700") References: <101220051447 DOT 16978 DOT 434D21E5000D25EB0000425222007610640A050E040D0C079D0A AT comcast DOT net> <87r7aqqvie DOT fsf AT penguin DOT cs DOT ucla DOT edu> Date: Thu, 13 Oct 2005 09:22:54 +0200 Message-ID: <87u0flg9td.fsf@rho.meyering.net> Lines: 25 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Paul Eggert wrote: > ericblake AT comcast DOT net (Eric Blake) writes: >> The algorithm change between 5.3.0 and 5.90 in lib/mkdir-p.c to >> try mkdir() first instead of stat(), and key off of EEXIST, breaks >> when mkdir() fails with EROFS on an intermediate directory when >> the writable directory has been mounted inside a read-only tree. > > Thanks for reporting this. It is indeed a bug in > coreutils/lib/mkdir-p.c. It can be triggered by other errors too. > This is hard to write a test case for, but I'd like to fix things. > Does the following patch work for you? > > Jim, if this works for Eric, is it OK to install this patch at this late > date? Nice patch. This seems safe enough, so yes, please apply. Thanks! > 2005-10-12 Paul Eggert > > * mkdir-p.c (make_dir_parents): Don't fail if an intervening mkdir > fails due to EROFS, or due to EEXIST or other reasons for that matter. > Problem reported by Eric Blake. > (ENOSYS): Remove; no longer needed. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/