Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
From: ericblake AT comcast DOT net (Eric Blake)
To: "Hans W. Horn" <hannes AT 2horns DOT com>, cygwin AT cygwin DOT com
Subject: Re: Bash 2.05 vs. 3.0 Prompt Behavior [attn readline maintainer]
Date: Sat, 09 Jul 2005 20:46:35 +0000
Message-Id: <070920052046.9327.42D037AB000B28480000246F22073007930A050E040D0C079D0A@comcast.net>
X-Authenticated-Sender: ZXJpY2JsYWtlQGNvbWNhc3QubmV0

>> Hi Eric,
>> 
>> I fixed this minor issue (so I believe) in my early attempts in
>> becoming a bash maintainer sometime in april this year.
>> I've attached a patch file (based on bash-3.0-7).
>> 
>> greets,
>> H.

Hans was kind enough to provide me his proposed patch offlist, which
boils down to this:

--- bash-3.0/lib/readline/display.c     2005-07-06 05:59:59.000000000 -0600
+++ bash-3.0/lib/readline/display.c     2005-07-09 07:57:13.632987200 -0700
@@ -269,6 +269,7 @@
                }
              else
                ninvis++;               /* invisible chars byte counter */
+               last++;
            }

          if (invflset == 0 && rl >= _rl_screenwidth)

But I have some questions about it.  First, Hans, did you forget some {}
so that the increment of last occurs only on the else block, or else
why did you indent it at the same level?  Second, this is in a readline
file, so do you want to look closer at it, Charles?

--
Eric Blake



--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/