Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Sat, 28 May 2005 23:07:14 +0200 (CEST)
From: Vaclav Haisman <V DOT Haisman AT sh DOT cvut DOT cz>
To: cygwin AT cygwin DOT com
Subject: hires_ms::usecs in winsup/cygwin/times.cc
Message-ID: <20050528225106.H63183@logout.sh.cvut.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Reply-To: cygwin AT cygwin DOT com


I have found some odd code in hires_ms::usecs in times.cc around line 600.
There is condition like this: if ((now - initime_ms) < 0). The problem is that
both of the variables are unsigned (DWORD) and the result is unsigned and this
comparison can never be true because unsigned number can never be < 0.

The code should either involve some cast to signed type or should be completely
removed.


VH.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/