Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Wed, 11 May 2005 16:49:52 -0700
From: David Rothenberger <daveroth AT acm DOT org>
Subject: Re: Fixing strace and cygcheck so that they work with mount -X
In-reply-to: <42828A27.5050206@mscha.org>
To: cygwin AT cygwin DOT com
Message-id: <42829A20.2030209@acm.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
References: <Pine DOT GSO DOT 4 DOT 61 DOT 0505081605450 DOT 21700 AT slinky DOT cs DOT nyu DOT edu>  <20050508230637 DOT GD3896 AT trixie DOT casa DOT cgf DOT cx>  <Pine DOT GSO DOT 4 DOT 61 DOT 0505081958360 DOT 21700 AT slinky DOT cs DOT nyu DOT edu>  <20050509002126 DOT GH3896 AT trixie DOT casa DOT cgf DOT cx>  <20050509022611 DOT GA7850 AT trixie DOT casa DOT cgf DOT cx> <427F9C41 DOT 1000605 AT acm DOT org>  <427FB7B2 DOT 8040903 AT mscha DOT nl> <20050510151746 DOT GV15665 AT trixie DOT casa DOT cgf DOT cx>  <42822503 DOT 2090903 AT mscha DOT org> <20050511154036 DOT GD10119 AT trixie DOT casa DOT cgf DOT cx>  <20050511165354 DOT GA15412 AT trixie DOT casa DOT cgf DOT cx> <428255DA DOT 4030907 AT acm DOT org>  <42828A27 DOT 5050206 AT mscha DOT org>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
X-IsSubscribed: yes
Reply-To: cygwin AT cygwin DOT com

On 5/11/2005 3:41 PM, Michael Schaap wrote:
> The patch as-is doesn't compile for me, though, I presume because
>     char **envp = (char **) cygwin_internal (CW_ENVP);
> uses a not-yet-released Cygwin enhancement.  But when I change it to the
> simpler and more standard
>     char **envp = environ;
> it compiles and works fine, both under mount -X and normally.

Doh! I didn't read Chris' last comment carefully enough. Yes, copying 
from environ is much more reasonable.

> (At first I was a bit suspicious of the logic - it only sets those
> Windows variables that are not currently set, so what about variables
> that were changed or deleted within Cygwin? - but it looks like the
> Windows environment isn't the standard pre-Cygwin user environment, but
> a minimal one with only PATH and SYSTEMROOT set, so it actually does
> behave optimally this way - it sets all other variables when running
> under mount -X, and sets nothing otherwise.)

Right. The main reason I did that, though, was because copying the 
Cygwin PATH to the Windows environment caused lots of core dumps.

> Revised patch attached.  Can you try this out and see if it still works
> for you?  If you confirm this, I'll resend the patch in a new, more
> obviously titled thread, to attract Chuck's attention.  ;-)

Works fine for me. Start attracting!

-- 
David Rothenberger                spammer? -> spam AT daveroth DOT dyndns DOT org
GPG/PGP: 0x7F67E734, C233 365A 25EF 2C5F C8E1 43DF B44F BA26 7F67 E734

To Perl, or not to Perl, that is the kvetching.
              -- Larry Wall in <199801200310 DOT TAA11670 AT wall DOT org>


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/