Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
To: Eric Blake <ebb9 AT byu DOT net>
Cc: "Pierre A. Humblet" <Pierre DOT Humblet AT ieee DOT org>, cygwin AT cygwin DOT com,
   bug-coreutils AT gnu DOT org
Subject: Re: mkdir -p and network drives
References: <3 DOT 0 DOT 5 DOT 32 DOT 20050502232204 DOT 00b52180 AT incoming DOT verizon DOT net> <42777719 DOT 8090103 AT byu DOT net> <8764xym6vf DOT fsf AT penguin DOT cs DOT ucla DOT edu> <427AD935 DOT 1010409 AT byu DOT net>
From: Paul Eggert <eggert AT CS DOT UCLA DOT EDU>
Date: Thu, 05 May 2005 20:47:00 -0700
In-Reply-To: <427AD935.1010409@byu.net> (Eric Blake's message of "Thu, 05 May 2005 20:40:53 -0600")
Message-ID: <87vf5x818r.fsf@penguin.cs.ucla.edu>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Eric Blake <ebb9 AT byu DOT net> writes:

>> +      if (do_chdir && dirpath[0] == '/')
>> +	{
>> +	  /* POSIX says "//" might be special, so chdir to "//" if the
>> +	     file name starts with exactly two slashes.  */
>> +	  char const *root = "//" + (dirpath[1] != '/' || dirpath[2] == '/');
>
> Oops - buffer overflow bug.  dirpath[2] is past the end of the string on
> dirpath of "/",

If dirpath is "/", then dirpath[1] != '/' is true, so dirpath[2] isn't
evaluated.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/