Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Sat, 23 Apr 2005 14:41:13 -0400 (EDT)
From: Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: support dirent.d_type
In-Reply-To: <20050422170611.GL16791@trixie.casa.cgf.cx>
Message-ID: <Pine.GSO.4.61.0504231437380.28480@slinky.cs.nyu.edu>
References: <BAY22-F19EF6A1D9FA240BE4394C2FF2D0 AT phx DOT gbl> <Pine DOT GSO DOT 4 DOT 61 DOT 0504221136390 DOT 25885 AT slinky DOT cs DOT nyu DOT edu> <20050422170611 DOT GL16791 AT trixie DOT casa DOT cgf DOT cx>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Fri, 22 Apr 2005, Christopher Faylor wrote:

> On Fri, Apr 22, 2005 at 11:37:59AM -0400, Igor Pechtchanski wrote:
> >On Fri, 22 Apr 2005, lode leroy wrote:
> >>I would like to see support for dirent.d_type added to cygwin.
> >>
> >>fhandler_disk_file::readdir()
> >>{
> >>...
> >> if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
> >>   dir->__d_dirent->d_type = DT_DIR;
> >> } else {
> >>   dir->__d_dirent->d_type = DT_REG;
> >> }
> >>...
> >>}
> >
> >So why not make it a patch, test it, and send it to the appropriate list
> >with a ChangeLog entry?  For something this small you don't even need a
> >copyright assignment.  See <http://cygwin.com/contrib.html>.
>
> Actually, thanks but I don't think we want to go down this path.
>
> Properly implementing this field would introduce the same problems as
> properly implementing d_ino.  Doing this would mean adding too much
> overhead to readdir.

I didn't say that the patch would be accepted.  IMO, having an actual
patch in hand would make it easier to review the suggestion, and, if
necessary, to articulate the reasons for rejecting it.  Also, if the OP
had tried the actual patch, he would have realized that, with all the
missing features added, the patch would not be quite as trivial as he
imagined.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"The Sun will pass between the Earth and the Moon tonight for a total
Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/