Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Fri, 22 Apr 2005 13:06:11 -0400
From: Christopher Faylor <cgf-no-personal-reply-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: support dirent.d_type
Message-ID: <20050422170611.GL16791@trixie.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
References: <BAY22-F19EF6A1D9FA240BE4394C2FF2D0 AT phx DOT gbl> <Pine DOT GSO DOT 4 DOT 61 DOT 0504221136390 DOT 25885 AT slinky DOT cs DOT nyu DOT edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.GSO.4.61.0504221136390.25885@slinky.cs.nyu.edu>
User-Agent: Mutt/1.5.8i

On Fri, Apr 22, 2005 at 11:37:59AM -0400, Igor Pechtchanski wrote:
>On Fri, 22 Apr 2005, lode leroy wrote:
>>I would like to see support for dirent.d_type added to cygwin.
>>
>>fhandler_disk_file::readdir()
>>{
>>...
>> if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
>>   dir->__d_dirent->d_type = DT_DIR;
>> } else {
>>   dir->__d_dirent->d_type = DT_REG;
>> }
>>...
>>}
>
>So why not make it a patch, test it, and send it to the appropriate list
>with a ChangeLog entry?  For something this small you don't even need a
>copyright assignment.  See <http://cygwin.com/contrib.html>.

Actually, thanks but I don't think we want to go down this path.

Properly implementing this field would introduce the same problems as
properly implementing d_ino.  Doing this would mean adding too much
overhead to readdir.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/