Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Message-ID: <422CFC2C.1000706@mscha.org>
Date: Tue, 08 Mar 2005 02:13:16 +0100
From: Michael Schaap <cygwin AT mscha DOT org>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: cygstart patch
References: <49D88D820A7BC0479A7B0932D4219EFE1A4BD0 AT NAEAPAXREX04VA DOT nadsusea DOT nads DOT navy DOT mil> <4227D42B DOT 8040904 AT cwilson DOT fastmail DOT fm>
In-Reply-To: <4227D42B.8040904@cwilson.fastmail.fm>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Note-from-DJ: This may be spam

Hi Anthony, Chuck, all,

On 4-Mar-2005 4:21, Charles Wilson wrote:

> Anthony --
>
> I've applied this patch. Thanks!


Sorry for jumping in so late...

While I agree that the revised patch looks good and does the job, I'm 
not too happy with the constant reallocation that's going on. (I know, 
there won't be a measurable performance impact, but it, well, just looks 
wring to me. ;-) )

In any case, here's a proposed alternative patch (against the version 
containing Anthony's patch already) which calculates the actual total 
argument size in advance, before allocating.
(In addition, I've taken the opportunity to change the listed email 
address (cygwin_start at mscha dot org), which I had to block long ago 
due to the ongoing stream of spam and viruses, to a new one, obscured 
this time. Plus, I changed the feedback address to the mailing list 
address (also obscured), since the list is obviously much more 
responsive than I am. :-/ )

Chuck, if this looks OK to you, can you apply this patch?

Thanks, also to Anthony and all for everything you've done.

– Michael

PS: That free() bug was very embarrassing... :-[ (Hmm... why do I even 
draw attention to that again? ;-) )

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/