Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Subject: RE: cygstart patch
Date: Thu, 3 Mar 2005 09:44:04 -0500
Message-ID: <49D88D820A7BC0479A7B0932D4219EFE1DD0EF@NAEAPAXREX04VA.nadsusea.nads.navy.mil>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
From: "Derosa, Anthony  CIV NAVAIR 2035, 2, 205/214" <Anthony DOT Derosa1 AT navy DOT mil>
To: <cygwin AT cygwin DOT com>
X-OriginalArrivalTime: 03 Mar 2005 14:44:05.0969 (UTC) FILETIME=[7331C410:01C51FFF]
X-IsSubscribed: yes
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id j23EjanC027668

> Mind the spaces/tabs in the *original* code.  As long as what
> you edited in your newly-added (or replacement) code,
> it should still apply.

Igor, thanks.  I didn't modify the original - only my changes.
I asked because I didn't know if the diff format contains
some checksum that would be messed up by *any* changes.  I
guess the format is about as simple as it looks.

One more question: should I have changed the version of the
program in the patch, or is that up to the maintainer?

-Anthony

> -----Original Message-----
> From: Igor Pechtchanski [mailto:pechtcha AT cs DOT nyu DOT edu]
> Sent: Thursday, March 03, 2005 9:34
> To: Derosa, Anthony CIV NAVAIR 2035, 2, 205/214
> Cc: cygwin AT cygwin DOT com
> Subject: RE: cygstart patch
> 
> 
> On Thu, 3 Mar 2005, Derosa, Anthony  CIV NAVAIR 2035, 2, 
> 205/214 wrote:
> 
> > What do you think about Chuck's concerns regarding strcat()
> > vs. strncat()?
> 
> I'm no expert either, but usually the purpose of strncat() is 
> to avoid a
> buffer overrun when copying an arbitrary-sized string into a
> statically-sized buffer (as the string may be longer than the buffer).
> Since you're sizing the buffer dynamically to the exact string size, I
> don't think there's anything wrong with using strcpy/strcat 
> here (as long
> as you check that the buffer is not NULL -- and you do).
> 
> > (I *didn't* regenerate this with diff, is that OK?
> > I just changed the "1" to "2" and removed some whitespace.):
> 
> Mind the spaces/tabs in the *original* code.  As long as what 
> you edited
> is in your newly-added (or replacement) code, it should still apply.
> HTH,
> 	Igor
> 
> > > From: cygwin-owner AT XXXXXX DOT XXX 
> [mailto:cygwin-owner AT XXXXXX DOT XXX]On Behalf Of Dave Korn
> > > To: cygwin AT XXXXXX DOT XXX
> 
> Oh, and <http://cygwin.com/acronyms/#PCYMTNQREAIYR>.  Thanks.
> -- 
> 				http://cs.nyu.edu/~pechtcha/
>       |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
> ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
>      |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
>     '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!
> 
> "The Sun will pass between the Earth and the Moon tonight for a total
> Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT
> 

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/