Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Subject: cygstart patch
Date: Wed, 2 Mar 2005 11:09:07 -0500
Message-ID: <49D88D820A7BC0479A7B0932D4219EFE1DD0EC@NAEAPAXREX04VA.nadsusea.nads.navy.mil>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
From: "Derosa, Anthony  CIV NAVAIR 2035, 2, 205/214" <Anthony DOT Derosa1 AT navy DOT mil>
To: <cygwin AT cygwin DOT com>
X-OriginalArrivalTime: 02 Mar 2005 16:09:09.0807 (UTC) FILETIME=[2AE7E3F0:01C51F42]
X-IsSubscribed: yes
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id j22GAgKk001051

I found a small bug and added a feature to the cygstart utility, which is part of the cygutils package.  The feature that I added removes the limit on the length of the command line arguments passed to the target application, which was previously limited to MAX_PATH.  The bug I fixed was in regard to freeing the variable "args" instead of tyring to free "workDir" twice.  A patch and change log follow below.  As this is my first contribution, please correct me if I did something incorrectly.

-Anthony


Change Log

2005-03-02  Anthony DeRosa  <Anthony dot DeRosa1 at navy dot mil>

* cygstart.c (main): removed limit on the length of command line arguments passed to the target application

* cygstart.c (main): fixed typo that freed the variable "workDir" twice instead of freeing "args"


Patch

--- ../cygutils-1.2.6/src/cygstart/cygstart.c	2002-03-16 00:49:44.000000000 -0500
+++ src/cygstart/cygstart.c	2005-03-02 09:16:00.383625000 -0500
@@ -340,14 +340,18 @@ int main(int argc, const char **argv)
 
     /* Retrieve any arguments */
     if (rest && *rest) {
-        if ((args = (char *) malloc(MAX_PATH+1)) == NULL) {
+        if ((args = (char *) malloc(strlen(*rest)+1)) == NULL) {
             fprintf(stderr, "%s: memory allocation error\n", argv[0]);
             exit(1);
-        }
-        strncpy(args, *rest, MAX_PATH);
+        }	 
+        strcpy(args, *rest);
         while (rest++ && *rest) {
-            strncat(args, " ", MAX_PATH-strlen(args));
-            strncat(args, *rest, MAX_PATH-strlen(args));
+            if ( (args = (char *) realloc(args, strlen(args) + strlen(*rest) + 1)) == NULL) {
+                fprintf(stderr, "%s: memory allocation error\n", argv[0]);
+                exit(1);
+            }		
+            strcat(args, " ");
+            strcat(args, *rest);
         }
     }
 
@@ -359,7 +363,7 @@ int main(int argc, const char **argv)
     if (action)
         free(action);
     if (args)
-        free(workDir);
+        free(args);
     if (workDir)
         free(workDir);
     if (file)

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/