Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Tue, 18 Jan 2005 15:23:56 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Fwd: Re: more coreutils 5.3.0 issues on cygwin
Message-ID: <20050118142356.GY3113@cygbert.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <41ED16DB DOT 3020701 AT byu DOT net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41ED16DB.3020701@byu.net>
User-Agent: Mutt/1.4.2i

On Jan 18 07:02, Eric Blake wrote:
> Corinna, why did you change od in coreutils 5.2.1?  When I proposed your
> patch upstream, the maintainers pointed out that 12 lines later in the
> same method, the code is calling setmode(fd, O_BINARY) for all non-tty
> input filenames that were just fopen'd.  Does cygwin have a working
> setmode (and if not, does fcntl(fd, F_SETFL, O_BINARY | fcntl(fd,
> F_GETFL)) work as expected)?

He's of course right.  Just keep the patch in as a Cygwin local patch
which shouldn't go upstream.  What happened was that od failed to read
files in binary mode on textmode mounts.  It turned out that recent
Cygwin/newlib changes resulted in setmode only working correctly on
the stdio descriptors 0, 1 and 2.  This is fixed in CVS, but the
problem persists in 1.5.12.  The patch circumvents that problem in
1.5.12, but it will become unnecessary later on.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/