Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Message-ID: <03da01c4eea2$bcec1e40$5308a8c0@robinson.cam.ac.uk>
From: "Max Bowsher" <maxb AT ukf DOT net>
To: <cygwin AT cygwin DOT com>
References: <02e901c4ee99$48826a90$5308a8c0 AT robinson DOT cam DOT ac DOT uk> <20041230185131 DOT GD1212 AT trixie DOT casa DOT cgf DOT cx>
Subject: Re: Bug: Missing va_end() in cygwin_internal()
Date: Thu, 30 Dec 2004 19:05:29 -0000
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes

Christopher Faylor wrote:
> On Thu, Dec 30, 2004 at 05:59:02PM -0000, Max Bowsher wrote:
>> There is no va_end() call in cygwin_internal().
>
> Or in functions from:
>
>  bsdlib.cc
>  fork.cc
>  pinfo.cc
>  strace.cc
>
> The lack doesn't seem to be causing much of a problem...

Standards say va_end is required, but may be a noop in some implementations.

I peered at the guts of gcc trying to work out whether that was the case for 
cygwin, but got too lost to be sure.

I thought it was worth mentioning, because I think I'm going to need to use 
cygwin_internal(CW_GET_BINMODE, ...) a lot, in order to get Subversion's 
"native" eol-style feature noticing textmode mounts.

Max.


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/