Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Thu, 30 Sep 2004 12:06:47 -0400 (EDT)
From: Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH] cygrunsrv --recovery <action>
In-Reply-To: <20040930153543.GC29206@cygbert.vinschen.de>
Message-ID: <Pine.GSO.4.61.0409301204000.14979@slinky.cs.nyu.edu>
References: <42404 DOT 193 DOT 16 DOT 155 DOT 145 DOT 1096475468 DOT squirrel AT webmail DOT kainz DOT com> <20040930153543 DOT GC29206 AT cygbert DOT vinschen DOT de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Scanned-By: MIMEDefang 2.39

On Thu, 30 Sep 2004, Corinna Vinschen wrote:

> On Sep 29 18:31, Rainer Hochreiter wrote:
> > the attached patch implements the options -r or --recovery to set service
> > failure actions. allowed actions are 'none', 'boot' or 'restar'.
> > not implemented are actions for running commands on failed actions, like
> > supported by the windows SCM.
> >
> > the patch also uses ChangeServiceConfig2() for setting the description of
> > the installed service.
>
> Thanks for the patch, but I can't apply it as it is, mainly  for two
> reasons.
>
> > not included is the ChangeLog of the patch!
>
> - This is reason one.
>
> - Please don't use ChangeServiceConfig2.  It will break running cygrunsrv
>   on NT4.  That's the reason the description is written directly to the
>   registry instead of using ChangeServiceConfig2.
>
> Also, what's the reason you didn't implement running commands?  I'm asking
> because there are still these `#if 0' parts left in your patch which point
> to the fact that you began to implement it but just stopped at one point.
>
> Corinna

And when you resubmit, please use "diff -u" instead of "diff -c" -- the
patch is much more readable that way.

One immediate change I noticed was that the description parameter migrated
from calls to install_registry_keys to calls to install_service, but you
haven't provided any changes to either of those functions.  Any reason for
this?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Happiness lies in being privileged to work hard for long hours in doing
whatever you think is worth doing."  -- Dr. Jubal Harshaw

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/