Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Message-ID: <414749A7.809@agilent.com> Date: Tue, 14 Sep 2004 12:42:31 -0700 From: Earl Chew User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207) MIME-Version: 1.0 To: cygwin AT cygwin DOT com Subject: Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c References: <414532D7 DOT 8050506 AT agilent DOT com> <41472B3F DOT 8030800 AT agilent DOT com> In-Reply-To: <41472B3F.8030800@agilent.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Sep 2004 19:42:32.0807 (UTC) FILETIME=[FA46E770:01C49A92] Christopher Faylor wrote: > Let me again point out that a cygwin program shouldn't be doing *ANY OF > THIS*. > > It shouldn't be calling GetFileSize and it shouldn't be calling > CreateFile. I think part of the original motivation might have been that under some circumstances this set of programs needs to be used on drive partitions as opposed to files within those partitions. At that time there may have been no way within Cygwin to size a partition (statfs()?). As far as I can tell the O_BINARY changes are good to have. Earl -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/