Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: RTLD_DEFAULT & RTLD_NEXT
Mail-Copies-To: never
Reply-To: sds AT gnu DOT org
X-Attribution: Sam
X-Disclaimer: You should not expect anyone to agree with me.
From: Sam Steingold <sds AT gnu DOT org>
In-Reply-To: <20040831190826.GV17670@cygbert.vinschen.de> (Corinna Vinschen's message of "Tue, 31 Aug 2004 21:08:26 +0200")
References: <u65704sup DOT fsf AT gnu DOT org> <20040830143832 DOT GE17670 AT cygbert DOT vinschen DOT de> <uisb018x4 DOT fsf AT gnu DOT org> <20040831083258 DOT GA7517 AT cygbert DOT vinschen DOT de> <u1xhn1gaz DOT fsf AT gnu DOT org> <20040831190826 DOT GV17670 AT cygbert DOT vinschen DOT de>
Mail-Followup-To: cygwin AT cygwin DOT com
Date: Tue, 31 Aug 2004 15:35:34 -0400
Message-ID: <uoekrxfqx.fsf@gnu.org>
User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (windows-nt)
MIME-Version: 1.0
Content-Type: text/plain

> * Corinna Vinschen <pbevaan-pltjva AT pltjva DOT pbz> [2004-08-31 21:08:26 +0200]:
>
> On Aug 31 11:24, Sam Steingold wrote:
>> > * Corinna Vinschen <pbevaan-pltjva AT pltjva DOT pbz> [2004-08-31 10:32:58 +0200]:
>> > EnumProcessModules.  This should also allow to implement RTLD_DEFAULT.
>> 
>> 2004-08-31  Sam Steingold  <sds AT gnu DOT org>
>> 
>> 	* dlfcn.cc (dlsym): Handle RTLD_DEFAULT using EnumProcessModules().
>> 	* include/dlfcn.h (RTLD_DEFAULT): Define to NULL.
>
> thanks but... well, there are a couple of problems:
>
> - Please send patches to cygwin-patches@...
did.

> - Your code doesn't follow the GNU coding style.
yuk!!!

> - EnumProcessModules is NT >= 4 only but not loaded dynamically (see
> autoload.cc) nor tested for non-existance.  Generally,
> EnumProcessModules is called w/o checking the return value.

1. what is "n" in LoadDLLfunc?

2. how do I test for non-existance?

3. the first call to EnumProcessModules is known to fail. it is there
   for that specific reason - to fail and return "needed".

> - This is adding new functionality.  It's not much over the usual 10
> lines rule of thumb for trivial patches, but it's not exactly trivial
> functionality and it will only grow bigger when adding the autoload
> and return value testing code.  I'd like to ask you to read
> http://cygwin.com/contrib.html and send us a copyright assignment if
> possible.

ok.

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
A computer scientist is someone who fixes things that aren't broken.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/