Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Wed, 24 Mar 2004 21:39:29 -0500
From: "Pierre A. Humblet" <pierre DOT humblet AT ieee DOT org>
To: cygwin AT cygwin DOT com
Subject: Re: lstat on FAT - Was: Problem with find on FAT drives
Message-ID: <20040325023929.GA335381@hpn5170x>
Mail-Followup-To: "Pierre A. Humblet" <pierre DOT humblet AT ieee DOT org>, cygwin AT cygwin DOT com
References: <Pine DOT LNX DOT 4 DOT 44 DOT 0403231316380 DOT 32093-100000 AT ashi DOT FootPrints DOT net> <4060B627 DOT 8000400 AT scytek DOT de> <20040324155332 DOT GF17229 AT cygbert DOT vinschen DOT de> <4061E702 DOT 1040705 AT scytek DOT de> <20040324205644 DOT GA4580 AT redhat DOT com> <20040324213057 DOT GA296803 AT Worldnet> <20040324214239 DOT GA6079 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040324214239.GA6079@redhat.com>
User-Agent: Mutt/1.4.1i

On Wed, Mar 24, 2004 at 04:42:39PM -0500, Christopher Faylor wrote:
> On Wed, Mar 24, 2004 at 04:30:57PM -0500, Pierre A. Humblet wrote:
> >
> >I also had a look at the code and reached pretty much the same conclusion
> >as Volker. Replacing all 'isslash (*src)' and 'isslash (src[x])' in
> >normalize_posix_path by "isdirsep ()" would yield more consistent results.
> >I know this code is delicate but the possible drawback isn't obvious.
> 
> speed disadvantage for nebulous gain.
 
As you know isdirsep would take 1 extra compare per character.

FWIW I see one place where we could avoid the kind of loop that Volker had.

I wonder if 
      char *p = strrchr (src, '\0');
      /* Detect if the user was looking for a directory.  We have to strip the
should be inside the symlink loop or outside. I guess that depends if
symlink contents ending with / are special (on Sun the final / is stripped in
symlinks, dunno about other Unix flavors).

Also normalize_posix_path strips the final /, except when it calls 
normalize_win32_path. That makes the code go through extra hoops
when resolving c:/the/symlink/, it looks for c:/the/symlink/.lnk

Pierre


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/