Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com X-Authentication-Warning: slinky.cs.nyu.edu: pechtcha owned process doing -bs Date: Wed, 17 Mar 2004 18:11:04 -0500 (EST) From: Igor Pechtchanski Reply-To: cygwin AT cygwin DOT com To: cygwin AT cygwin DOT com Subject: [PATCH] cygrunsrv: mutual exclusion of -i and -u flags; typo fixes In-Reply-To: <20040313092914.GB32255@cygbert.vinschen.de> Message-ID: References: <20040313092914 DOT GB32255 AT cygbert DOT vinschen DOT de> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-684387517-1079565064=:25803" X-Scanned-By: MIMEDefang 2.39 ---559023410-684387517-1079565064=:25803 Content-Type: TEXT/PLAIN; charset=US-ASCII On Fri, 5 Mar 2004, Corinna Vinschen wrote: > On Mar 4 19:49, Igor Pechtchanski wrote: > > > > I think this relates to the fact that only services logging in with > > > the local system account can be configured to interact with the > > > desktop...so it appears that the --user and --interactive flags are > > > exclusive. > > > > Whoops, you're quite right (confirmed on MSDN). We should actually catch > > that in cygrunsrv and print out an appropriate error message. Corinna, > > should I prepare a patch, or do I need a copyright assignment for > > cygrunsrv? > > Nope, it's copyrighted by me, not by Red Hat. Go ahead :-) > Corinna On Thu, 4 Mar 2004, Igor Pechtchanski wrote: > P.S. Corinna, there's a bunch of typos in the cygrunsrv messages as well > ("neverexists" instead of "neverexits"). On Sat, 13 Mar 2004, Corinna Vinschen wrote: > On Mar 12 20:53, tony_silvaalummitedu wrote: > > > The option "--neverexits" is mispelled as "--neverexists" in the help > > function: > > Thanks for the hint. Fixed for the next version. > Corinna Corinna, Patch attached (fixes the --interactive with --user issue, and some leftover message typos). ChangeLog is below. Ok to commit? Igor ============================================================================== ChangeLog: 2004-03-17 Igor Pechtchanski * cygrunsrv.cc (service_main): Fix typo in comment. (main): Check that "--user" is not specified with "--interactive" (thanks to Peter Wisnovsky). * utils.h (reason_t): Add NoInteractiveWithUser value. * utils.cc (reason_list): Add description string for the NoInteractiveWithUser value. Fix typos in descriptions for the NeverExitsNotAllowed and OnlyOneNeverExits values. * cygrunsrv.README: Add comment about the "--interactive" option only being valid with a SYSTEM service. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha AT cs DOT nyu DOT edu ZZZzz /,`.-'`' -. ;-;;,_ igor AT watson DOT ibm DOT com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "I have since come to realize that being between your mentor and his route to the bathroom is a major career booster." -- Patrick Naughton ---559023410-684387517-1079565064=:25803 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="cygrunsrv-interactive-nouser.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="cygrunsrv-interactive-nouser.patch" SW5kZXg6IGN5Z3J1bnNydi5SRUFETUUNCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NClJDUyBmaWxlOiAvY3ZzL2N5Z3dpbi1hcHBzL2N5Z3J1bnNydi9jeWdy dW5zcnYuUkVBRE1FLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS44DQpkaWZm IC11IC1wIC1yMS44IGN5Z3J1bnNydi5SRUFETUUNCi0tLSBjeWdydW5zcnYu UkVBRE1FCTMgRmViIDIwMDQgMTQ6MzI6MzcgLTAwMDAJMS44DQorKysgY3ln cnVuc3J2LlJFQURNRQkxNyBNYXIgMjAwNCAyMjo1NjoyMSAtMDAwMA0KQEAg LTI1OSw2ICsyNTksNyBAQCBzeXN0ZW0gc2h1dGRvd24uDQogICBPcHRpb25h bCBmbGFnIHRoYXQgYWxsb3dzIGN5Z3J1bnNydiB0byBpbnRlcmFjdCB3aXRo IHRoZSBkZXNrdG9wLg0KIFdoZW4gaW4gZWZmZWN0LCBjeWdydW5zcnYgY2Fu IG9wZW4gd2luZG93cyBhbmQgcG9wIHVwIG1lc3NhZ2UgYm94ZXMuDQogRXF1 aXZhbGVudCB0byB0aGUgIkFsbG93IHNlcnZpY2UgdG8gaW50ZXJhY3Qgd2l0 aCBkZXNrdG9wIiBib3guDQorQ2Fubm90IGJlIHVzZWQgdW5sZXNzIHRoZSBz ZXJ2aWNlIHJ1bnMgYXMgU1lTVEVNLg0KIA0KICoqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCiBHZW5lcmFsIE5vdGVz Og0KSW5kZXg6IGN5Z3J1bnNydi5jYw0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KUkNTIGZpbGU6IC9jdnMvY3lnd2luLWFwcHMvY3lncnVuc3J2L2N5Z3J1 bnNydi5jYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjENCmRpZmYgLXUg LXAgLXIxLjIxIGN5Z3J1bnNydi5jYw0KLS0tIGN5Z3J1bnNydi5jYwkxNyBN YXIgMjAwNCAxNzowMToyNiAtMDAwMAkxLjIxDQorKysgY3lncnVuc3J2LmNj CTE3IE1hciAyMDA0IDIyOjU2OjIxIC0wMDAwDQpAQCAtMTI2Myw3ICsxMjYz LDcgQEAgc2VydmljZV9tYWluIChEV09SRCBhcmdjLCBMUFNUUiAqYXJndikN CiAgICAgICBlbHNlIGlmIChXSUZFWElURUQgKHN0YXR1cykpDQogICAgICAg ICB7DQogCSAgLyogQWx0aG91Z2ggd2UncmUgbm90IGdvaW5nIHRvIHNldCB0 aGUgc2VydmljZSBzdGF0dXMgdG8gc3RvcHBlZCwNCi0JICAgICBvbmx5IGFs bG93IHplcm8gZXhpdCBzdGF0dXMgaWYgbmV2ZXJleGlzdHMgaXMgbm90IHNl dC4gKi8NCisJICAgICBvbmx5IGFsbG93IHplcm8gZXhpdCBzdGF0dXMgaWYg bmV2ZXJleGl0cyBpcyBub3Qgc2V0LiAqLw0KIAkgIGlmICghbmV2ZXJleGl0 cykNCiAJICAgIGV4aXR2YWwgPSBXRVhJVFNUQVRVUyAoc3RhdHVzKTsNCiAJ ICBzeXNsb2dfc3RhcnRlcnIgKCJleGVjdiIsIDAsIFdFWElUU1RBVFVTIChz dGF0dXMpKTsNCkBAIC0xNDEzLDYgKzE0MTMsOCBAQCBtYWluIChpbnQgYXJn YywgY2hhciAqKmFyZ3YpDQogCSAgcmV0dXJuIGVycm9yIChJbnRlcmFjdGl2 ZU5vdEFsbG93ZWQpOw0KIAlpZiAoaW5faW50ZXJhY3RpdmUpDQogCSAgcmV0 dXJuIGVycm9yIChPbmx5T25lSW50ZXJhY3RpdmUpOw0KKwlpZiAoaW5fdXNl cikNCisJICByZXR1cm4gZXJyb3IgKE5vSW50ZXJhY3RpdmVXaXRoVXNlcik7 DQogCWluX2ludGVyYWN0aXZlID0gMTsNCiAJYnJlYWs7DQogICAgICAgY2Fz ZSAncyc6DQpAQCAtMTQ0NSw2ICsxNDQ3LDggQEAgbWFpbiAoaW50IGFyZ2Ms IGNoYXIgKiphcmd2KQ0KIAkgIHJldHVybiBlcnJvciAoVXNlck5vdEFsbG93 ZWQpOw0KIAlpZiAoaW5fdXNlcikNCiAJICByZXR1cm4gZXJyb3IgKE9ubHlP bmVVc2VyKTsNCisJaWYgKGluX2ludGVyYWN0aXZlKQ0KKwkgIHJldHVybiBl cnJvciAoTm9JbnRlcmFjdGl2ZVdpdGhVc2VyKTsNCiAJaW5fdXNlciA9IG9w dGFyZzsNCiAJYnJlYWs7DQogICAgICAgY2FzZSAndyc6DQpJbmRleDogdXRp bHMuY2MNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zz L2N5Z3dpbi1hcHBzL2N5Z3J1bnNydi91dGlscy5jYyx2DQpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMTMNCmRpZmYgLXUgLXAgLXIxLjEzIHV0aWxzLmNjDQot LS0gdXRpbHMuY2MJMTMgTWFyIDIwMDQgMDk6Mjg6NTQgLTAwMDAJMS4xMw0K KysrIHV0aWxzLmNjCTE3IE1hciAyMDA0IDIyOjU2OjIxIC0wMDAwDQpAQCAt NTksMTIgKzU5LDEzIEBAIGNoYXIgKnJlYXNvbl9saXN0W10gPSB7DQogICAi LS1kZXAgaXMgb25seSBhbGxvd2VkIHdpdGggLS1pbnN0YWxsIiwNCiAgICIt LXN0ZHtpbixvdXQsZXJyfSBhcmUgb25seSBhbGxvd2VkIHdpdGggLS1pbnN0 YWxsIiwNCiAgICJFYWNoIG9mIC0tc3Rke2luLG91dCxlcnJ9IGlzIGFsbG93 ZWQgb25seSBvbmNlIiwNCi0gICItLW5ldmVyZXhpc3RzIGlzIG9ubHkgYWxs b3dlZCB3aXRoIC0taW5zdGFsbCIsDQotICAiT25seSBvbmUgLS1uZXZlcmV4 aXN0cyBpcyBhbGxvd2VkIiwNCisgICItLW5ldmVyZXhpdHMgaXMgb25seSBh bGxvd2VkIHdpdGggLS1pbnN0YWxsIiwNCisgICJPbmx5IG9uZSAtLW5ldmVy ZXhpdHMgaXMgYWxsb3dlZCIsDQogICAiLS1zaHV0ZG93biBpcyBvbmx5IGFs bG93ZWQgd2l0aCAtLWluc3RhbGwiLA0KICAgIk9ubHkgb25lIC0tc2h1dGRv d24gaXMgYWxsb3dlZCIsDQogICAiLS1pbnRlcmFjdGl2ZSBpcyBvbmx5IGFs bG93ZWQgd2l0aCAtLWluc3RhbGwiLA0KICAgIk9ubHkgb25lIC0taW50ZXJh Y3RpdmUgaXMgYWxsb3dlZCIsDQorICAiLS1pbnRlcmFjdGl2ZSBub3QgYWxs b3dlZCB3aXRoIC0tdXNlciIsDQogICAiVHJhaWxpbmcgY29tbWFuZGxpbmUg YXJndW1lbnRzIG5vdCBhbGxvd2VkIiwNCiAgICJZb3UgbXVzdCBzcGVjaWZ5 IG9uZSBvZiB0aGUgYC1JUlNFJyBvcHRpb25zIiwNCiAgICJFcnJvciBpbnN0 YWxsaW5nIGEgc2VydmljZSIsDQpJbmRleDogdXRpbHMuaA0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvY3lnd2luLWFwcHMvY3ln cnVuc3J2L3V0aWxzLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEwDQpk aWZmIC11IC1wIC1yMS4xMCB1dGlscy5oDQotLS0gdXRpbHMuaAkzIEZlYiAy MDA0IDE0OjMyOjM3IC0wMDAwCTEuMTANCisrKyB1dGlscy5oCTE3IE1hciAy MDA0IDIyOjU2OjIxIC0wMDAwDQpAQCAtNTYsNiArNTYsNyBAQCBlbnVtIHJl YXNvbl90IHsNCiAgIE9ubHlPbmVTaHV0ZG93biwNCiAgIEludGVyYWN0aXZl Tm90QWxsb3dlZCwNCiAgIE9ubHlPbmVJbnRlcmFjdGl2ZSwNCisgIE5vSW50 ZXJhY3RpdmVXaXRoVXNlciwNCiAgIFRyYWlsaW5nQXJncywNCiAgIFN0YXJ0 QXNTdmNFcnIsDQogICBJbnN0YWxsRXJyLA0K ---559023410-684387517-1079565064=:25803 Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ ---559023410-684387517-1079565064=:25803--