Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
X-Authentication-Warning: slinky.cs.nyu.edu: pechtcha owned process doing -bs
Date: Sat, 14 Feb 2004 11:30:35 -0500 (EST)
From: Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH] Fix for broken package-grep.cgi (Attn: CGF)
In-Reply-To: <Pine.GSO.4.56.0402031457070.24268@slinky.cs.nyu.edu>
Message-ID: <Pine.GSO.4.56.0402141127340.26191@slinky.cs.nyu.edu>
References: <600B91D5E4B8D211A58C00902724252C01BC04D3 AT piramida DOT hermes DOT si> <Pine DOT GSO DOT 4 DOT 56 DOT 0401281005560 DOT 5576 AT slinky DOT cs DOT nyu DOT edu> <Pine DOT GSO DOT 4 DOT 56 DOT 0401281930240 DOT 1236 AT slinky DOT cs DOT nyu DOT edu> <20040129004128 DOT GB1624 AT redhat DOT com> <Pine DOT GSO DOT 4 DOT 56 DOT 0401282149010 DOT 4101 AT slinky DOT cs DOT nyu DOT edu> <Pine DOT GSO DOT 4 DOT 56 DOT 0402031457070 DOT 24268 AT slinky DOT cs DOT nyu DOT edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Scanned-By: MIMEDefang 2.39

Ping.  CGF, can we bring this to a close, please?  The patch below simply
escapes the filename in the link to package-cat.cgi...
	Igor

On Tue, 3 Feb 2004, Igor Pechtchanski wrote:

> Can we please revisit this?  It's already bitten one person that we know
> of (see <http://cygwin.com/ml/cygwin-apps/2004-02/msg00025.html>).
>
> If there's interest, I could also work on
> <http://cygwin.com/ml/cygwin/2004-01/msg01296.html>, but that's not as
> urgent.
>         Igor
>
> On Wed, 28 Jan 2004, Igor Pechtchanski wrote:
>
> > On Wed, 28 Jan 2004, Christopher Faylor wrote:
> >
> > > On Wed, Jan 28, 2004 at 07:38:26PM -0500, Igor Pechtchanski wrote:
> > > [snip]
> > > >ChangeLog:
> > > >2004-01-28  Igor Pechtchanski  <pechtcha AT cs DOT nyu DOT edu>
> > > >
> > > >       * package-grep.cgi (findheader): Quote raw filename in pattern.
> > >
> > > Please check in.
> > > Thanks,
> > > cgf
> >
> > Whoops, this was missing another piece.  The files with '+'s are now
> > properly displayed, but the links to the contents are screwed up, due to
> > '+' being translated into ' ' by the URL encoding/decoding.  Something
> > like
> >
> > Index: package-grep.cgi
> > ===================================================================
> > RCS file: /cvs/cygwin/htdocs/cgi-bin2/package-grep.cgi,v
> > retrieving revision 1.27
> > diff -u -p -r1.27 package-grep.cgi
> > --- package-grep.cgi    29 Jan 2004 02:32:47 -0000      1.27
> > +++ package-grep.cgi    29 Jan 2004 02:52:59 -0000
> > @@ -49,7 +49,7 @@ if (%main::packages) {
> >      for my $p (sort keys %main::packages) {
> >         for my $f (@{$main::packages{$p}}) {
> >             print '<tr><td><img src="http://sources.redhat.com/icons/ball.gray.gif" height=10 width=10 alt=""></td>',
> > -                  "<td cellspacing=10><a href=\"package-cat.cgi?file=$f&grep=" . uri_escape($grep) . '">' . $f . '</a></td><td align="left">' . findheader($p, $index) . "</td></tr>\n";
> > +                  "<td cellspacing=10><a href=\"package-cat.cgi?file=" . uri_escape($f) . "&grep=" . uri_escape($grep) . '">' . $f . '</a></td><td align="left">' . findheader($p, $index) . "</td></tr>\n";
> >         }
> >      }
> >  }
> >
> > should fix it.
> >         Igor

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/