Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com X-Authentication-Warning: slinky.cs.nyu.edu: pechtcha owned process doing -bs Date: Tue, 3 Feb 2004 15:00:30 -0500 (EST) From: Igor Pechtchanski Reply-To: cygwin AT cygwin DOT com To: cygwin AT cygwin DOT com Subject: Re: [PATCH] Fix for broken package-grep.cgi (Attn: CGF) In-Reply-To: Message-ID: References: <600B91D5E4B8D211A58C00902724252C01BC04D3 AT piramida DOT hermes DOT si> <20040129004128 DOT GB1624 AT redhat DOT com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Can we please revisit this? It's already bitten one person that we know of (see ). If there's interest, I could also work on , but that's not as urgent. Igor On Wed, 28 Jan 2004, Igor Pechtchanski wrote: > On Wed, 28 Jan 2004, Christopher Faylor wrote: > > > On Wed, Jan 28, 2004 at 07:38:26PM -0500, Igor Pechtchanski wrote: > > [snip] > > >ChangeLog: > > >2004-01-28 Igor Pechtchanski > > > > > > * package-grep.cgi (findheader): Quote raw filename in pattern. > > > > Please check in. > > Thanks, > > cgf > > Whoops, this was missing another piece. The files with '+'s are now > properly displayed, but the links to the contents are screwed up, due to > '+' being translated into ' ' by the URL encoding/decoding. Something > like > > Index: package-grep.cgi > =================================================================== > RCS file: /cvs/cygwin/htdocs/cgi-bin2/package-grep.cgi,v > retrieving revision 1.27 > diff -u -p -r1.27 package-grep.cgi > --- package-grep.cgi 29 Jan 2004 02:32:47 -0000 1.27 > +++ package-grep.cgi 29 Jan 2004 02:52:59 -0000 > @@ -49,7 +49,7 @@ if (%main::packages) { > for my $p (sort keys %main::packages) { > for my $f (@{$main::packages{$p}}) { > print '', > - "' . $f . '' . findheader($p, $index) . "\n"; > + "' . $f . '' . findheader($p, $index) . "\n"; > } > } > } > > should fix it. > Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha AT cs DOT nyu DOT edu ZZZzz /,`.-'`' -. ;-;;,_ igor AT watson DOT ibm DOT com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "I have since come to realize that being between your mentor and his route to the bathroom is a major career booster." -- Patrick Naughton -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/