Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Subject: Re: Patch to allow CVS cygwin enable-malloc-debugging to compile To: cygwin AT cygwin DOT com Message-ID: From: "Michael Checky" Date: Fri, 13 Jun 2003 14:20:47 -0500 MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii X-MW-BTID: 090225000020031647100200012 X-MW-CTIME: 1055533402 HOP-COUNT: 1 X-MAILWATCH-INSTANCEID: 010200139e2ed337-4eaa-4718-af74-88a6e39bcfc8 X-OriginalArrivalTime: 13 Jun 2003 19:43:22.0664 (UTC) FILETIME=[0C633A80:01C331E4] On Thu, 12 Jun 2003, Christopher Faylor wrote: > Don't bother. This patch is unacceptable for cygwin. Randomly adding > '#if 0' to a header and '#ifndef __CYGWIN__' to cygwin code is not ever > going to be accepted. I didn't submit the patch to be applied to the cygwin sources, I submitted it to illustrate the changes I had to make in order to get the --enable-malloc-debugging option to compile and run. Since this option is currently broken, I assume the cygwin maintainers will want to fix it. BTW, 'random' was not the method I used to insert the #if's. The #if 0 comments out a data structure that should not have been declared in that particular header file, since that exact same data structure was declared in a standard header file. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/