Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Message-ID: <01a901c2df3c$3b1c2fd0$78d96f83@pomello> From: "Max Bowsher" To: "Sheridan, David" , References: <7D6AD971A503D311BBB100805FA75F9F06E6DA10 AT ns0107 DOT uk DOT nomura DOT com> Subject: Re: cygwin rsync bug with windows shares Date: Fri, 28 Feb 2003 15:15:29 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 Sheridan, David wrote: > I'm using the cygwin version of rsync (2.5.5) and think I've found a > bug which is harmless under unix but fatal to cygwin. The bug is also > in the latest source version I could find (2.5.6). > > If I'm trying to take a file from (windows-style) > \\share\directory\filename I would specify something like > rsync //share/directory/filename destination > However, there is special handling in rsync to stop // at the > beginning of a filename, presumably to cope with unix systems which > can't understand the convention. Specifically, in syscall.c, about > line 93, in the do_open() function, the first / is skipped over in > this case. > > The result of this as I have seen it is that rsync will correctly > identify all files in a directory that need to be copied, but > complains that none of them exist (since do_open() is only relevant > to the remote-syncing function, not directory listing). I can > overcome it by saying something like > rsync ///share/directory/filename destination > but that seems a bit silly. > > My solution would be to include a cygwin-specific patch for this line, > rather than asking the rsync project to patch their code, but cygwin > developers may disagree. The rsync maintainers are quite considerate about this kind of thing. I think they would probably accept this kind of fix into the upstream sources. Max. -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/