Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Sun, 29 Dec 2002 00:23:17 -0600
From: Steve O <bub AT io DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: small tty problem? Re: Updated: cygwin-1.3.18-1
Message-ID: <20021229002317.A21445@eris.io.com>
References: <20021225233434 DOT GA5624 AT redhat DOT com> <3 DOT 0 DOT 5 DOT 32 DOT 20021225190753 DOT 00837100 AT h00207811519c DOT ne DOT client2 DOT attbi DOT com> <20021227024759 DOT GA14435 AT redhat DOT com> <20021227215045 DOT GA35279159 AT HPN5170X> <20021227222900 DOT GA29157 AT redhat DOT com> <20021228062514 DOT GA20824 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20021228062514.GA20824@redhat.com>; from cgf@redhat.com on Sat, Dec 28, 2002 at 01:25:14AM -0500

On Sat, Dec 28, 2002 at 01:25:14AM -0500, Christopher Faylor wrote:
> Well, surprise, this bugged me enough that I had to track it down.  The
> order of acceptance of input and echoing of input seemed to have been
> changed by Steve's recent patches, so I put it back the way it was
> before.

Hi,

Just got back from holiday and followed your fix trajectory for this. 
Nice.  Removing always_accept may remove the requirement for the 
post-loop setting of ret to line_edit_input_done.  I'll have to stare
at it some more though.

As for the placement of doecho, it was moved after accept_input since
doecho is not undoable.  So, if accept_input fails repeatedly, the current
code could echo a character multiple times.  However, given the 
circumstances, I agree that moving doecho back is the correct thing to do
in the short term. 

My next set of patches should remedy this by adding an echobuf that
will essentially make echo characters be read before the slave input. 
Undoubtedly, someone will find a case where this isn't correct, but 
for now I can't think of what that case may be. 

Thank you, cgf, for taking time out of your holidays to look at this.

-steve

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/