Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
X-Authentication-Warning: slinky.cs.nyu.edu: pechtcha owned process doing -bs
Date: Thu, 14 Nov 2002 13:12:07 -0500 (EST)
From: Igor Pechtchanski <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: cygwin AT cygwin DOT com
Subject: Re: console title
In-Reply-To: <20021114180356.GB2581@redhat.com>
Message-ID: <Pine.GSO.4.44.0211141309350.4275-100000@slinky.cs.nyu.edu>
Importance: Normal
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

Ouch.  I actually did before I sent the message...

The source uses plain "char" declaration.  The signedness of that, IIRC,
depends on the compile-time gcc flags, or gcc defaults.  Hence the
question.
	Igor

On Thu, 14 Nov 2002, Christopher Faylor wrote:

> On Thu, Nov 14, 2002 at 12:52:04PM -0500, Igor Pechtchanski wrote:
> >Are characters signed, or unsigned?
>
> Take a look at the source:
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/fhandler_console.cc?rev=1.95&cvsroot=src
>
> cgf
>
> >> >--- fhandler_console.cc.orig   Thu Nov 14 14:51:30 2002
> >> >+++ fhandler_console.cc        Thu Nov 14 15:01:54 2002
> >> >@@ -1530,7 +1530,7 @@
> >> >       case gettitle:
> >> >         {
> >> >           int n = strlen (dev_state->my_title_buf);
> >> >-          if (*src < ' ' || *src >= '\177')
> >> >+          if (*src < ' ' || *src >= 0377)
> >> >             {
> >> >               if (*src == '\007' && dev_state->state_ == gettitle)
> >> >                 {

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha AT cs DOT nyu DOT edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor AT watson DOT ibm DOT com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/