Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Thu, 14 Nov 2002 12:48:24 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: console title
Message-ID: <20021114174824.GA3238@redhat.com>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <200211140723 DOT QAA24914 AT udlew10 DOT uldev DOT lsi DOT nec DOT co DOT jp> <200211141446 DOT XAA25395 AT udlew10 DOT uldev DOT lsi DOT nec DOT co DOT jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200211141446.XAA25395@udlew10.uldev.lsi.nec.co.jp>
User-Agent: Mutt/1.5.1i

On Thu, Nov 14, 2002 at 11:46:23PM +0900, Hironori SAKAMOTO wrote:
>Sorry, I made a mistake.
>
>> When a window title of cygwin console is displayed with escape
>> sequence (\033]0;title\007), it can't be displayed if it includes
>> non-ASCII characters (\200..\0377).
>> Is the following patch acceptable ?
>
>This is the correct patch.

This can't be correct.  It's not possible for a character to be greater
than 0377 anyway so your change is meaningless.

I'll just remove the >= '\177' entirely.  Somebody (me) obviously wasn't
thinking globally when they wrote that.  This will be in a snapshot soon.

cgf

>--- fhandler_console.cc.orig	Thu Nov 14 14:51:30 2002
>+++ fhandler_console.cc	Thu Nov 14 15:01:54 2002
>@@ -1530,7 +1530,7 @@
> 	case gettitle:
> 	  {
> 	    int n = strlen (dev_state->my_title_buf);
>-	    if (*src < ' ' || *src >= '\177')
>+	    if (*src < ' ' || *src >= 0377)
> 	      {
> 		if (*src == '\007' && dev_state->state_ == gettitle)
> 		  {

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/