Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Message-ID: <1031656920.3d7dd5d8c4a7f@mail.broadpark.no> Date: Tue, 10 Sep 2002 13:22:00 +0200 From: dvasaru AT broadpark DOT no To: cygwin AT cygwin DOT com Subject: Re: [ANNOUNCEMENT] Updated: bash-2.05b-4 References: <20020908120848 DOT 0E3E11B95E AT redhat DOT com> <20020910091502 DOT E1574 AT cygbert DOT vinschen DOT de> In-Reply-To: <20020910091502.E1574@cygbert.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-MOQ1031656920aa0c60cdbf9d239307144665908e8998" User-Agent: Internet Messaging Program (IMP) 3.0 X-Originating-IP: 192.18.243.4 ---MOQ1031656920aa0c60cdbf9d239307144665908e8998 Content-Type: text/plain; charset=windows-1252;q=1.0 Content-Transfer-Encoding: 8bit Quoting Corinna Vinschen : > On Tue, Sep 10, 2002 at 08:01:00AM +0200, Dan Vasaru wrote: > > I'll give this a go in gdb as it seems to have caused problems for some > > users. Did you just remove the fd_is_seekable ifdef ? > Yes, I announced -5 yesterday, reverting that again. The problem is with the way text seeks are (not) implemented in cygwin: lseek in text files do not adjust for skipped CRs. This is also the strategy MS is using in their CRT, so it may be the most MSVCRT/CYGWIN compatible solution. So it seems that applications that use lseek on text files should handle CRLF translation by themselves, at least for now. In the case of bash, CRLF translation seems to have been implemented by the DJGPP port. I just removed (almost) all __CYGWIN__ textmode translation related #ifdefs, and enabled the DJGPP CR removal hack in buffered_getchar (). Preliminary testing shows the new bash to work on both CRLF and LF files. Files are no longer opened in O_TEXT mode, but CR's are stripped in buffered_getchar. In case anyone is interested in testing out the new bash, I'm attaching a diff to bash-2.05b-3-src.tar.bz2, and I can provide a prebuilt bash.exe. dan ---MOQ1031656920aa0c60cdbf9d239307144665908e8998 Content-Type: application/octet-stream; name="bashdiff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="bashdiff" ZGlmZiAtcmMgYmFzaC0yLjA1Yi0zL2J1aWx0aW5zL2V2YWxmaWxlLmMgYmFzaC0yLjA1Yi02L2J1 aWx0aW5zL2V2YWxmaWxlLmMKKioqIGJhc2gtMi4wNWItMy9idWlsdGlucy9ldmFsZmlsZS5jCVRo dSBGZWIgMjEgMjE6MDg6NTIgMjAwMgotLS0gYmFzaC0yLjA1Yi02L2J1aWx0aW5zL2V2YWxmaWxl LmMJVHVlIFNlcCAxMCAxMjo0MzoxOSAyMDAyCioqKioqKioqKioqKioqKgoqKiogMTIxLDEzMCAq KioqCiAgICAgICAgcmV0dXJuICgoZmxhZ3MgJiBGRVZBTF9CVUlMVElOKSA/IEVYRUNVVElPTl9G QUlMVVJFIDogLTEpOwogICAgICB9ICAgICAgCiAgCi0gI2lmIGRlZmluZWQgKF9fQ1lHV0lOX18p ICYmIGRlZmluZWQgKE9fVEVYVCkKLSAgIHNldG1vZGUgKGZkLCBPX1RFWFQpOwotICNlbmRpZgot IAogICAgc3RyaW5nID0gKGNoYXIgKil4bWFsbG9jICgxICsgZmlsZV9zaXplKTsKICAgIHJlc3Vs dCA9IHJlYWQgKGZkLCBzdHJpbmcsIGZpbGVfc2l6ZSk7CiAgICBzdHJpbmdbcmVzdWx0XSA9ICdc MCc7Ci0tLSAxMjEsMTI2IC0tLS0KZGlmZiAtcmMgYmFzaC0yLjA1Yi0zL2lucHV0LmMgYmFzaC0y LjA1Yi02L2lucHV0LmMKKioqIGJhc2gtMi4wNWItMy9pbnB1dC5jCU1vbiBTZXAgMTAgMTk6MjY6 NDggMjAwMQotLS0gYmFzaC0yLjA1Yi02L2lucHV0LmMJVHVlIFNlcCAxMCAxMzoxMDo0NSAyMDAy CioqKioqKioqKioqKioqKgoqKiogMzIxLDMzMSAqKioqCiAgfQogIAogIC8qIFJldHVybiAxIGlm IGEgc2VlayBvbiBGRCB3aWxsIHN1Y2NlZWQuICovCi0gI2lmbmRlZiBfX0NZR1dJTl9fCiAgIyAg ZGVmaW5lIGZkX2lzX3NlZWthYmxlKGZkKSAobHNlZWsgKChmZCksIDBMLCBTRUVLX0NVUikgPj0g MCkKLSAjZWxzZQotICMgIGRlZmluZSBmZF9pc19zZWVrYWJsZShmZCkgMAotICNlbmRpZiAvKiBf X0NZR1dJTl9fICovCiAgCiAgLyogVGFrZSBGRCwgYSBmaWxlIGRlc2NyaXB0b3IsIGFuZCBjcmVh dGUgYW5kIHJldHVybiBhIGJ1ZmZlcmVkIHN0cmVhbQogICAgIGNvcnJlc3BvbmRpbmcgdG8gaXQu ICBJZiBzb21ldGhpbmcgaXMgd3JvbmcgYW5kIHRoZSBmaWxlIGRlc2NyaXB0b3IKLS0tIDMyMSwz MjcgLS0tLQoqKioqKioqKioqKioqKioKKioqIDQ0NSw0NTkgKioqKgogICAgICAgIHJldHVybiAo RU9GKTsKICAgICAgfQogIAotICNpZiBkZWZpbmVkIChfX0NZR1dJTl9fKQotICAgLyogSWYgb24g Y3lnd2luLCB0cmFuc2xhdGUgXHJcbiB0byBcbi4gKi8KLSAgIGlmIChuciA+PSAyICYmIGJwLT5i X2J1ZmZlcltuciAtIDJdID09ICdccicgJiYgYnAtPmJfYnVmZmVyW25yIC0gMV0gPT0gJ1xuJykK LSAgICAgewotICAgICAgIGJwLT5iX2J1ZmZlcltuciAtIDJdID0gJ1xuJzsKLSAgICAgICBuci0t OwotICAgICB9Ci0gI2VuZGlmCi0gCiAgICBicC0+Yl91c2VkID0gbnI7CiAgICBicC0+Yl9pbnB1 dHAgPSAwOwogICAgcmV0dXJuIChicC0+Yl9idWZmZXJbYnAtPmJfaW5wdXRwKytdICYgMHhGRik7 Ci0tLSA0NDEsNDQ2IC0tLS0KKioqKioqKioqKioqKioqCioqKiA1MDAsNTA2ICoqKioKICBpbnQK ICBidWZmZXJlZF9nZXRjaGFyICgpCiAgewohICNpZiAhZGVmaW5lZCAoREpHUFApCiAgICByZXR1 cm4gKGJ1ZnN0cmVhbV9nZXRjIChidWZmZXJzW2Jhc2hfaW5wdXQubG9jYXRpb24uYnVmZmVyZWRf ZmRdKSk7CiAgI2Vsc2UKICAgIC8qIE9uIERKR1BQLCBpZ25vcmUgXHIuICovCi0tLSA0ODcsNDkz IC0tLS0KICBpbnQKICBidWZmZXJlZF9nZXRjaGFyICgpCiAgewohICNpZiAhZGVmaW5lZCAoREpH UFApICYmICFkZWZpbmVkKF9fQ1lHV0lOX18pCiAgICByZXR1cm4gKGJ1ZnN0cmVhbV9nZXRjIChi dWZmZXJzW2Jhc2hfaW5wdXQubG9jYXRpb24uYnVmZmVyZWRfZmRdKSk7CiAgI2Vsc2UKICAgIC8q IE9uIERKR1BQLCBpZ25vcmUgXHIuICovCmRpZmYgLXJjIGJhc2gtMi4wNWItMy9zaGVsbC5jIGJh c2gtMi4wNWItNi9zaGVsbC5jCioqKiBiYXNoLTIuMDViLTMvc2hlbGwuYwlNb24gSnVsICAxIDE3 OjI3OjExIDIwMDIKLS0tIGJhc2gtMi4wNWItNi9zaGVsbC5jCVR1ZSBTZXAgMTAgMTI6NDM6MTkg MjAwMgoqKioqKioqKioqKioqKioKKioqIDEzNDMsMTM1MiAqKioqCiAgICAgICBub3QgbWF0Y2gg d2l0aCBvdXJzLiAqLwogICAgZmQgPSBtb3ZlX3RvX2hpZ2hfZmQgKGZkLCAwLCAtMSk7CiAgCi0g I2lmIGRlZmluZWQgKF9fQ1lHV0lOX18pICYmIGRlZmluZWQgKE9fVEVYVCkKLSAgIHNldG1vZGUg KGZkLCBPX1RFWFQpOwotICNlbmRpZgotIAogICNpZiBkZWZpbmVkIChCVUZGRVJFRF9JTlBVVCkK ICAgIGRlZmF1bHRfYnVmZmVyZWRfaW5wdXQgPSBmZDsKICAgIFNFVF9DTE9TRV9PTl9FWEVDIChk ZWZhdWx0X2J1ZmZlcmVkX2lucHV0KTsKLS0tIDEzNDMsMTM0OCAtLS0tCg== ---MOQ1031656920aa0c60cdbf9d239307144665908e8998 Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ ---MOQ1031656920aa0c60cdbf9d239307144665908e8998--