Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Date: Tue, 18 Jun 2002 13:06:02 -0400 From: Jason Tishler Subject: Re: Rebase 1.5-1: Causes invalid page fault In-reply-to: <20020618160910.86155.qmail@web21002.mail.yahoo.com> To: Nicholas Wourms Cc: cygwin AT cygwin DOT com Mail-followup-to: Nicholas Wourms , cygwin AT cygwin DOT com Message-id: <20020618170601.GI1568@tishler.net> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_AzJJ9cEooNd0VVINbcYZeg)" User-Agent: Mutt/1.4i References: <20020618160003 DOT GH1568 AT tishler DOT net> <20020618160910 DOT 86155 DOT qmail AT web21002 DOT mail DOT yahoo DOT com> --Boundary_(ID_AzJJ9cEooNd0VVINbcYZeg) Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline Nicholas, On Tue, Jun 18, 2002 at 09:09:10AM -0700, Nicholas Wourms wrote: > --- Jason Tishler wrote: > > pathname is null terminated -- this is good. Is it null terminated for > > *all* DLLs? > > I'm going to have to start printing the arguments one by one as I step > through the execution, because it crashes before it can do the next loop. > So in effect, the other dlls aren't being processed yet. Hmm... I just noticed that maybe the SymbolPath argument should be "" (i.e., the empty string) and not 0 (i.e., the null pointer). Please try the attached patch. Does this fix rebase for you? Thanks, Jason --Boundary_(ID_AzJJ9cEooNd0VVINbcYZeg) Content-type: text/plain; charset=us-ascii; NAME=rebase.c.diff Content-transfer-encoding: 7BIT Content-disposition: attachment; filename=rebase.c.diff --- rebase.c 2002/05/10 12:00:54 1.5 +++ rebase.c 2002/06/18 17:01:06 @@ -56,7 +56,7 @@ main (int argc, char *argv[]) get_pathname (argv[i], pathname, sizeof (pathname)); prev_new_image_base = new_image_base; aStatus = ReBaseImage (pathname, /* CurrentImageName */ - 0, /* SymbolPath */ + "", /* SymbolPath */ TRUE, /* fReBase */ FALSE, /* fRebaseSysfileOk */ down_flag, /* fGoingDown */ --Boundary_(ID_AzJJ9cEooNd0VVINbcYZeg) Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ --Boundary_(ID_AzJJ9cEooNd0VVINbcYZeg)--