Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Fri, 24 May 2002 18:46:14 +0200
From: Pavel Tsekov <ptsekov AT syntrex DOT com>
Reply-To: Pavel Tsekov <cygwin AT cygwin DOT com>
Organization: Syntrex, Inc.
X-Priority: 3 (Normal)
Message-ID: <19430013927.20020524184614@syntrex.com>
To: "Max Bowsher" <maxb AT ukf DOT net>
CC: cygwin AT cygwin DOT com
Subject: Re: Setup 2.243 - Crash isolated
In-Reply-To: <01f101c20339$08999fa0$42a18c09@wdg.uk.ibm.com>
References: <01f101c20339$08999fa0$42a18c09 AT wdg DOT uk DOT ibm DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hello Max,

Friday, May 24, 2002, 5:36:38 PM, you wrote:

Do you know a way of how to reproduce this ? I'll try it later
today when I'm at home.

MB> I have isolated the crash I was getting. It was similar to what Pavel suggested,
MB> but in a different place.

MB> It is caused by rfc1738_do_escape calling strlen(url) when url is NULL.

MB> Here is a stack trace:

MB> #0  rfc1738_do_escape (url=0x0, encode_reserved=1) at ../rfc1738.cc:82
MB> #1  0x004340ac in rfc1738_escape_part (url=@0x125a238) at ../rfc1738.cc:195
MB> #2  0x0040c5cf in check_for_cached (pkgsource=@0x11d8ed8) at ../download.cc:91
MB> #3  0x004043c6 in scan_downloaded_files () at ../choose.cc:471
MB> #4  0x004045d1 in ChooserPage::OnInit (this=0x23fb60) at ../choose.cc:517

MB> A kludge in rfc1738_do_escape avoids the crash, and allows setup to continue.

MB> I will need to study setup some more before I can track this down to its root
MB> cause.

MB> Max.


MB> --
MB> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
MB> Bug reporting:         http://cygwin.com/bugs.html
MB> Documentation:         http://cygwin.com/docs.html
MB> FAQ:                   http://cygwin.com/faq/


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/