Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Date: Sat, 18 May 2002 17:08:06 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: Remote dirs in fhandler_disk_file::fstat()? Message-ID: <20020518210806.GA25202@redhat.com> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <3CE52A74 DOT C7B61D8 AT cern DOT ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CE52A74.C7B61D8@cern.ch> User-Agent: Mutt/1.3.23.1i On Fri, May 17, 2002 at 06:06:12PM +0200, Lassi A. Tuura wrote: >I have been reading cygwin code trying to understand it better, hoping >to contribute to it later. Pretty cool treasure trove of Windows code >I must say. I have a question on fhandler_disk_file.cc (rev 1.9). In >fhandler_disk_file::fstat(), line 114 onwards there is this code: > > else if (pc->exists ()) > { > /* Unfortunately, the above open may fail if the file exists, though. > So we have to care for this case here, too. */ > WIN32_FIND_DATA wfd; > HANDLE handle; > buf->st_nlink = 1; > if (pc->isdir () && pc->isremote ()) > buf->st_nlink = num_entries (pc->get_win32 ()); > >Should that be `... && ! pc->isremote ())'? At least the code above, >various ChangeLog and cvs log messages and the message from Corinna >(http://www.cygwin.com/ml/cygwin-developers/2000-03/msg00091.html) >suggest so. If so, I'll be happy to whip up a patch. Yes, I think you're right. I've checked in a patch. Thanks for noticing this. cgf -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/