Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Date: Wed, 10 Apr 2002 12:06:13 +0200 From: Pavel Tsekov Reply-To: Pavel Tsekov Organization: Syntrex, Inc. X-Priority: 3 (Normal) Message-ID: <08165371.20020410120613@syntrex.com> To: cygwin AT cygwin DOT com CC: rjlpub AT kc DOT rr DOT com, cygwin-patches AT cygwin DOT com Subject: Re[2]: Cygwin 1.3.10 Setup.exe 2.194.2.22 Install Problems With MSVCRT.DLL and source code on Win98 In-Reply-To: <1921297856.20020410101146@syntrex.com> References: <000401c1e033$e5bce3c0$0301a8c0 AT kc DOT rr DOT com> <1921297856 DOT 20020410101146 AT syntrex DOT com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----------321D8C7338E6328" ------------321D8C7338E6328 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello, there! :) Wednesday, April 10, 2002, 10:11:46 AM, you wrote: Ok, found it - its canonicalize_version() in version.cc. There is a pointer 'v' which is modified and then delete[]'d. A trivial patch is attached :) 2002-04-10 Pavel Tsekov * version.cc (canonicalize_version): Fix a call delete[] to delete. PT> Wednesday, April 10, 2002, 4:03:24 AM, you wrote: rkrc>> Two major problems (summary): rkrc>> 1. Setup.exe (2.194.2.22) ends with a invalid page fault against MSVCRT.DLL rkrc>> (details below) on my Windows 98 machine, before complely fininshing the rkrc>> install. PT> I have not investigated this yet - but from what I see the crash is PT> similiar to one reported earlier to the ml. The address at which the PT> crash occurs is inside the code of a helper function for PT> free() and realloc(). PT> I'll look into this maybe this night. PT> P.S. Thanks for the very good description of your problem :) ------------321D8C7338E6328 Content-Type: application/octet-stream; name="version.cc.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="version.cc.diff" LS0tIHZlcnNpb24uY2MJTW9uIEZlYiAxOCAyMzoxNTowMiAyMDAyCisrKyB2ZXJzaW9uLmNjLmZp eGVkCVdlZCBBcHIgMTAgMTA6MDA6MjMgMjAwMgpAQCAtMzIsNiArMzIsNyBAQCBTdHJpbmcgCiBj YW5vbmljYWxpemVfdmVyc2lvbiAoU3RyaW5nIGNvbnN0ICZhU3RyaW5nKQogewogICBjaGFyICp2 ID1hU3RyaW5nLmNzdHIoKTsKKyAgY2hhciAqdnNhdmUgPSB2OwogICBzdGF0aWMgY2hhciBudlsz XVsxMDBdOwogICBzdGF0aWMgaW50IGlkeCA9IDA7CiAgIGNoYXIgKm5wOwpAQCAtNTUsNiArNTYs NiBAQCBjYW5vbmljYWxpemVfdmVyc2lvbiAoU3RyaW5nIGNvbnN0ICZhU3RyCiAJKm5wKysgPSAq disrOwogICAgIH0KICAgKm5wKysgPSAwOwotICBkZWxldGVbXSB2OworICBkZWxldGVbXSB2c2F2 ZTsKICAgcmV0dXJuIG52W2lkeF07CiB9Cg== ------------321D8C7338E6328 Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ ------------321D8C7338E6328--