Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Thu, 14 Mar 2002 13:15:54 +0100
From: Corinna Vinschen <cygwin AT cygwin DOT com>
To: cygwin <cygwin AT cygwin DOT com>
Subject: Re: poll() bugs and patch
Message-ID: <20020314131554.I29574@cygbert.vinschen.de>
Mail-Followup-To: cygwin <cygwin AT cygwin DOT com>
References: <20020313181423 DOT C29574 AT cygbert DOT vinschen DOT de> <LOBBKDBPKEGJJFKNFHKBCEPEGJAA DOT boriss AT web DOT de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <LOBBKDBPKEGJJFKNFHKBCEPEGJAA.boriss@web.de>
User-Agent: Mutt/1.3.22.1i

On Wed, Mar 13, 2002 at 10:20:30PM +0100, Boris Schaeling wrote:
> > Ok with me.  However, I'll not take that patch w/o a ChangeLog entry.
> > Please create one, Boris.
> 
> Here they are:
> - change.log
> - poll.patch
> - newpoll.cc (new implementation)
> - polltest.c (testcase)

Thanks for the patch.  I've applied it with some changes.  Sorry for
being picky but your indenting wasn't GNU coding style conformant.
It's not

  if ()
  {
    foo;
  }

but

  if ()
    {
      foo;
    }

I've fixed that for now.  Your ChangeLog isn't correct either but
I've fixed that too:

Not

        * poll.cc: variable open_fds removed, rearranged
	and added code to fix settings of revents

but

        * poll.cc: Remove variable open_fds, rearrange and add code
	to fix settings of revents.

Present tense, full stop.

Check out the next developers snapshot or update from CVS to see
your patch incorporated.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/