Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Mon, 11 Mar 2002 12:57:26 +0100
From: Corinna Vinschen <cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH] cygrunsrv --query <service>
Message-ID: <20020311125726.L29574@cygbert.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <1015617879 DOT 22818 DOT 78 DOT camel AT aurl0668>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1015617879.22818.78.camel@aurl0668>
User-Agent: Mutt/1.3.22.1i

On Fri, Mar 08, 2002 at 03:04:38PM -0500, Mike Gerdts wrote:
> The following patch implements the options -Q and --query to determine
> if a service is installed and if so whether it is up and what controls
> it will accept.

Cool patch!  Thanks, I've applied it to the CVS repository and I'm
going to upload a new version of cygrunsrv soon.

> If there is a more appropriate place to send this patch, please let me
> know.

Yes, you could send that stuff to cygwin-apps AT cygwin DOT com.  If you
don't want to subscribe to YA mailing list, just keep it here.

A side note though, related to your ChangeLog entry.

First, it's not correct.  Bullets only for a new file entry; don't repeat
long texts if avoidable.  Better:


  2002-03-08  Mike Gerdts <Michael DOT Gerdts AT alcatel DOT com>

	  * utils.h (reason_t): Add code for --query errors.
	  * utils.cc (reason_list): Add error string for --query errors.
	  (usage): Add help text for --query parameter.
	  * cygrunsrv.cc (longopts): Add --query parameter.
	  (opts): Add -Q option.
	  (main): Add handling --query parameter.
	  (serviceTypeToString): New function to support --query parameter.
	  (serviceStateToString): Ditto.
	  (serviceStateToString): Ditto.
	  (controlsToString): Ditto.
	  (query_service): Ditto.

Second, please don't send ChangeLog entries as part of the diff.
Send them always separately clear text.  You never know if the
ChangeLog hasn't changed in the meantime and diffs to ChangeLogs
never apply cleanly then.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/