Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Tue, 19 Feb 2002 12:27:54 -0500
From: Jason Tishler <jason AT tishler DOT net>
Subject: Re: Proposed patch for bash (completion spec problem related)
In-reply-to: <020219140501.AA76103.SM@nike.ins.cwru.edu>
To: cygwin AT cygwin DOT com
Mail-followup-to: cygwin AT cygwin DOT com
Message-id: <20020219172754.GC568@hp.com>
MIME-version: 1.0
Content-type: multipart/mixed; boundary="Boundary_(ID_Pffb44hPglUcXbgoqOGCdg)"
User-Agent: Mutt/1.3.24i
References: <020219140501 DOT AA76103 DOT SM AT nike DOT ins DOT cwru DOT edu>

--Boundary_(ID_Pffb44hPglUcXbgoqOGCdg)
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
Content-disposition: inline

On Tue, Feb 19, 2002 at 09:05:01AM -0500, Chet Ramey wrote:
> On Mon, Feb 18, 2002 at 05:06:36PM -0800, AJ Reins wrote:
> > Possible patch for bash to fix the problem noticed by Jason Tishler in msg:
> > http://sources.redhat.com/ml/cygwin/2002-02/msg00581.html
> > 
> > [snip]

AJ, thanks for tracking down this problem.

> The right fix is to replace the call to whitespace() with one to spctabnl().
> There's another fix needed for skip_to_delim(), ...

Chet, thanks for reviewing AJ's patch.

Corinna, attached is AJ's patch redone with a call to spctabnl() but
without the unknown fix to skip_to_delim().  Nevertheless, Cygwin bash
2.05a, with this patch, can now handle completion specs.  Would you be
willing to release a new bash 2.05a with this patch?

Thanks,
Jason

--Boundary_(ID_Pffb44hPglUcXbgoqOGCdg)
Content-type: text/plain; charset=us-ascii; NAME=subst.c.diff
Content-transfer-encoding: 7BIT
Content-disposition: attachment; filename=subst.c.diff

--- subst.c.orig	Tue Feb 19 09:29:06 2002
+++ subst.c	Tue Feb 19 09:30:01 2002
@@ -1339,7 +1339,7 @@ split_at_delims (string, slen, delims, s
 	break;
 
       i = te /* + member (string[te], d) */;
-      while (member (string[i], d) && whitespace(string[i]))
+      while (member (string[i], d) && spctabnl (string[i]))
 	i++;
 
       if (string[i])


--Boundary_(ID_Pffb44hPglUcXbgoqOGCdg)
Content-Type: text/plain; charset=us-ascii

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/
--Boundary_(ID_Pffb44hPglUcXbgoqOGCdg)--