Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Mon, 21 Jan 2002 10:38:08 +0100
From: Corinna Vinschen <cygwin AT cygwin DOT com>
To: cygwin <cygwin AT cygwin DOT com>
Subject: Re: security.cc: bug report, question and suggestion
Message-ID: <20020121103808.F11608@cygbert.vinschen.de>
Mail-Followup-To: cygwin <cygwin AT cygwin DOT com>
References: <3 DOT 0 DOT 5 DOT 32 DOT 20020119165218 DOT 007e3720 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020118194603 DOT 007db100 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20011230112615 DOT 00813e60 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20011229152301 DOT 0083a1f0 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20011229152301 DOT 0083a1f0 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20011230112615 DOT 00813e60 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020118194603 DOT 007db100 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020119165218 DOT 007e3720 AT pop DOT ne DOT mediaone DOT net> <3 DOT 0 DOT 5 DOT 32 DOT 20020119190251 DOT 007ded90 AT pop DOT ne DOT mediaone DOT net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3.0.5.32.20020119190251.007ded90@pop.ne.mediaone.net>
User-Agent: Mutt/1.3.22.1i

On Sat, Jan 19, 2002 at 07:02:51PM -0500, Pierre A. Humblet wrote:
> At 12:33 AM 1/20/02 +0100, you wrote:
> >I'm not quite sure if I understand.  If the setgid() is made
> >while a impersonation is active, the setgid() should affect
> >the impersonation token.  
> 
> No, no, it changes the process token.  syscalls.cc:
>  if (!OpenProcessToken (GetCurrentProcess (),

You're right.  The function should affect the impersonation token
if impersonation is active, and the process token otherwise.

> >Good question.  However, I don't think it's unsafe to change
> >the primary group.  If it was successful, further securable
> >objects are created using the correct primary group.  If it
> >wasn't successful, nothing has changed, nothing got worse.
> 
> Yes, but it's undetermined (except if the caller really knows
> the Groups), which isn't so good. By using myself->gid you could 
> change the primary group on securable objects to what it should be.
> BTW, does the primary group need to be in the Groups there too?

No.  I understand the reasoning behind your arguments now.
Perhaps you're right and we could also live without setting
the primary group.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/