Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Message-ID: <019e01c199bd$1b463860$0200a8c0@lifelesswks>
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: "Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>,
   "Cygwin" <cygwin AT sources DOT redhat DOT com>
References: <006301c199bb$81ad31f0$651c440a AT BRAMSCHE>
Subject: Re: Problem with winsup/cinstall compilation
Date: Thu, 10 Jan 2002 20:56:41 +1100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
X-OriginalArrivalTime: 10 Jan 2002 09:56:42.0057 (UTC) FILETIME=[1ACC9B90:01C199BD]


===
----- Original Message -----
From: "Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>
To: "Cygwin" <cygwin AT sources DOT redhat DOT com>
Sent: Thursday, January 10, 2002 8:45 PM
Subject: Problem with winsup/cinstall compilation


> Hi,
>
> I've tried to compile a recent setup.exe from the cvs and got an error
while compiling
> mklink2.c about "function declaration isn't a prototype"
> I've found that in cinstall/Makefile.in the -Werror option is set, so
warnings causes
> compiling failures.
>
> What about this ? As I see there are two solutions for this.
>
> 1. remove the -Werror in Makefile.in
> CFLAGS :=
@CFLAGS@ -Werror -Winline -Wall -Wpointer-arith -Wcast-align\
>                               ^^^^^^^^
> -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \
> -Wmissing-declarations -Wcomments
>
> 2. fix the bad header.
>    This seems to me the better solution, so a patch for the w32api
header is appended.

2. is correct. The -Werror is there deliberately.

I don't see these errors however. What version of gcc are you building
with?
Also, why are you building against your system includes, not the winsup
includes? (see my compile line below. The patch looks ok though, you
should make a ChangeLog etc and send it to cygwin-patches.

Rob

$ make
gcc -L/usr/src/cygwin/build/i686-pc-cygwin/winsup -L/usr/src/cygwin/buil
d/i686-pc-cygwin/w
insup/cygwin -L/usr/src/cygwin/build/i686-pc-cygwin/winsup/w32api/lib -i
system /usr/src/sr
c/winsup/include -isystem /usr/src/src/winsup/cygwin/include -isystem
/usr/src/src/winsup/
w32api/include -isystem /usr/src/src/newlib/libc/sys/cygwin -isystem
/usr/src/src/newlib/l
ibc/sys/cygwin32 -B/usr/src/cygwin/build/i686-pc-cygwin/newlib/ -isystem
/usr/src/cygwin/b
uild/i686-pc-cygwin/newlib/targ-include -isystem
/usr/src/src/newlib/libc/include -MMD -g
-O2 -Werror -Winline -Wall -Wpointer-arith -Wcast-align -Wwrite-strings 
-Wstrict-prototype
s -Wmissing-prototypes -Wmissing-declarations -Wcomments -mno-cygwin -I.
 -I/usr/src/src/wi
nsup/cinstall -I/usr/src/src/winsup/mingw/include  -I/usr/src/src/winsup
/bz2lib -mwindows
-c -o mklink2.o ../../../../../src/winsup/cinstall/mklink2.c
make -C zlib libzcygw.a
CC="gcc -L/usr/src/cygwin/build/i686-pc-cygwin/winsup -L/usr/src/c
ygwin/build/i686-pc-cygwin/winsup/cygwin -L/usr/src/cygwin/build/i686-pc
-cygwin/winsup/w32
api/lib -isystem /usr/src/src/winsup/include -isystem
/usr/src/src/winsup/cygwin/include -
isystem /usr/src/src/winsup/w32api/include -isystem
/usr/src/src/newlib/libc/sys/cygwin -i
system
/usr/src/src/newlib/libc/sys/cygwin32 -B/usr/src/cygwin/build/i686-pc-cy
gwin/newlib
/ -isystem
/usr/src/cygwin/build/i686-pc-cygwin/newlib/targ-include -isystem
/usr/src/src/
newlib/libc/include"
CFLAGS='-MMD -g -O2 -Werror -Winline -Wall -Wpointer-arith -Wcast-ali
gn -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-de
clarations -Wcomme
nts -mno-cygwin -I. -I/usr/src/src/winsup/cinstall -I/usr/src/src/winsup
/mingw/include  -I
/usr/src/src/winsup/bz2lib -mwindows'
make[1]: Entering directory
`/usr/src/cygwin/build/i686-pc-cygwin/winsup/cinstall/zlib'
....

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/