Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com From: "Ralf Habacker" To: "Cygwin" Subject: Problem with winsup/cinstall compilation Date: Thu, 10 Jan 2002 10:45:15 +0100 Message-ID: <006301c199bb$81ad31f0$651c440a@BRAMSCHE> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0064_01C199C3.E37199F0" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 Importance: Normal ------=_NextPart_000_0064_01C199C3.E37199F0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hi, I've tried to compile a recent setup.exe from the cvs and got an error while compiling mklink2.c about "function declaration isn't a prototype" I've found that in cinstall/Makefile.in the -Werror option is set, so warnings causes compiling failures. What about this ? As I see there are two solutions for this. 1. remove the -Werror in Makefile.in CFLAGS := @CFLAGS@ -Werror -Winline -Wall -Wpointer-arith -Wcast-align\ ^^^^^^^^ -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \ -Wmissing-declarations -Wcomments 2. fix the bad header. This seems to me the better solution, so a patch for the w32api header is appended. Any comments to this ? Regards Ralf habacker AT BRAMSCHE ~/src/cvs.cygwin.com/build/winsup/cinstall $ make gcc -c -g -O2 -Werror -Winline -Wall -Wpointer-arith -Wcast-align -Wwrite-strings -Wstrict-pr ototypes -Wmissing-prototypes -Wmissi ng-declarations -Wcomments ... mklink2.c cc1.exe: warnings being treated as errors /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/windef.h:203: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/windef.h:204: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/windef.h:205: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/rpcdce.h:363: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/rpcdcep.h:112: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/rpcdcep.h:113: warning: function declaration isn't a prototype /home/habacker/src/cvs.cygwin.com/src/winsup/w32api/include/rpc.h:49: warning: function declaration isn't a prototype ------=_NextPart_000_0064_01C199C3.E37199F0 Content-Type: application/octet-stream; name="w32api_20010110.dif" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="w32api_20010110.dif" Index: include/objbase.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/objbase.h,v=0A= retrieving revision 1.3=0A= diff -u -b -B -p -r1.3 objbase.h=0A= --- objbase.h 2001/11/01 19:42:56 1.3=0A= +++ objbase.h 2002/01/10 09:45:43=0A= @@ -162,8 +162,8 @@ WINOLEAPI CoQueryProxyBlanket(IUnknown*,=0A= WINOLEAPI = CoSetProxyBlanket(IUnknown*,DWORD,DWORD,OLECHAR*,DWORD,DWORD,RPC_AUTH_IDE= NTITY_HANDLE, DWORD);=0A= WINOLEAPI CoCopyProxy(IUnknown*,IUnknown**);=0A= WINOLEAPI CoQueryClientBlanket(DWORD*,DWORD*,OLECHAR**, = DWORD*,DWORD*,RPC_AUTHZ_HANDLE*,DWORD*);=0A= -WINOLEAPI CoImpersonateClient();=0A= -WINOLEAPI CoRevertToSelf();=0A= +WINOLEAPI CoImpersonateClient(void);=0A= +WINOLEAPI CoRevertToSelf(void);=0A= WINOLEAPI CoQueryAuthenticationServices(DWORD*, = SOLE_AUTHENTICATION_SERVICE**);=0A= WINOLEAPI CoSwitchCallContext(IUnknown*,IUnknown**);=0A= WINOLEAPI CoGetInstanceFromFile(COSERVERINFO*, = CLSID*,IUnknown*,DWORD,DWORD,OLECHAR*,DWORD,MULTI_QI*);=0A= Index: include/rpc.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/rpc.h,v=0A= retrieving revision 1.1.1.1=0A= diff -u -b -B -p -r1.1.1.1 rpc.h=0A= --- rpc.h 2000/02/17 19:38:31 1.1.1.1=0A= +++ rpc.h 2002/01/10 09:45:44=0A= @@ -46,7 +46,7 @@ typedef long RPC_STATUS;=0A= #endif /* 0 */=0A= =0A= RPC_STATUS RPC_ENTRY RpcImpersonateClient(RPC_BINDING_HANDLE);=0A= -RPC_STATUS RPC_ENTRY RpcRevertToSelf();=0A= +RPC_STATUS RPC_ENTRY RpcRevertToSelf(void);=0A= long RPC_ENTRY I_RpcMapWin32Status(RPC_STATUS);=0A= #ifdef __cplusplus=0A= }=0A= Index: include/rpcdce.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/rpcdce.h,v=0A= retrieving revision 1.3=0A= diff -u -b -B -p -r1.3 rpcdce.h=0A= --- rpcdce.h 2001/01/26 21:05:20 1.3=0A= +++ rpcdce.h 2002/01/10 09:45:45=0A= @@ -360,7 +360,7 @@ RPC_STATUS RPC_ENTRY RpcIfIdVectorFree(R=0A= RPC_STATUS RPC_ENTRY = RpcEpResolveBinding(RPC_BINDING_HANDLE,RPC_IF_HANDLE);=0A= RPC_STATUS RPC_ENTRY = RpcBindingServerFromClient(RPC_BINDING_HANDLE,RPC_BINDING_HANDLE*);=0A= DECLSPEC_NORETURN void RPC_ENTRY RpcRaiseException(RPC_STATUS);=0A= -RPC_STATUS RPC_ENTRY RpcTestCancel();=0A= +RPC_STATUS RPC_ENTRY RpcTestCancel(void);=0A= RPC_STATUS RPC_ENTRY RpcCancelThread(void*);=0A= RPC_STATUS RPC_ENTRY UuidCreate(UUID*);=0A= signed int RPC_ENTRY UuidCompare(UUID*,UUID*, RPC_STATUS*);=0A= Index: include/rpcdcep.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/rpcdcep.h,v=0A= retrieving revision 1.3=0A= diff -u -b -B -p -r1.3 rpcdcep.h=0A= --- rpcdcep.h 2001/12/03 19:59:34 1.3=0A= +++ rpcdcep.h 2002/01/10 09:45:45=0A= @@ -109,8 +109,8 @@ long __stdcall I_RpcConnectionSetSockBuf=0A= long __stdcall I_RpcBindingSetAsync(HANDLE,RPC_BLOCKING_FUNCTION);=0A= long __stdcall I_RpcAsyncSendReceive(RPC_MESSAGE*,void*);=0A= long __stdcall I_RpcGetThreadWindowHandle(void**);=0A= -long __stdcall I_RpcServerThreadPauseListening();=0A= -long __stdcall I_RpcServerThreadContinueListening();=0A= +long __stdcall I_RpcServerThreadPauseListening(void);=0A= +long __stdcall I_RpcServerThreadContinueListening(void);=0A= long __stdcall I_RpcServerUnregisterEndpointA(unsigned char*,unsigned = char*);=0A= long __stdcall I_RpcServerUnregisterEndpointW(unsigned short*,unsigned = short*);=0A= #ifdef UNICODE=0A= Index: include/rpcndr.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/rpcndr.h,v=0A= retrieving revision 1.3=0A= diff -u -b -B -p -r1.3 rpcndr.h=0A= --- rpcndr.h 2000/11/01 00:37:23 1.3=0A= +++ rpcndr.h 2002/01/10 09:45:46=0A= @@ -249,7 +249,7 @@ typedef struct _MIDL_FORMAT_STRING {=0A= unsigned char Format[1];=0A= } MIDL_FORMAT_STRING;=0A= typedef void(__RPC_API *STUB_THUNK)(PMIDL_STUB_MESSAGE);=0A= -typedef long(__RPC_API *SERVER_ROUTINE)();=0A= +typedef long(__RPC_API *SERVER_ROUTINE)(void);=0A= typedef struct _MIDL_SERVER_INFO_ {=0A= PMIDL_STUB_DESC pStubDesc;=0A= const SERVER_ROUTINE *DispatchTable;=0A= Index: include/rpcnsip.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/rpcnsip.h,v=0A= retrieving revision 1.1.1.1=0A= diff -u -b -B -p -r1.1.1.1 rpcnsip.h=0A= --- rpcnsip.h 2000/02/17 19:38:31 1.1.1.1=0A= +++ rpcnsip.h 2002/01/10 09:45:46=0A= @@ -12,9 +12,9 @@ RPC_STATUS RPC_ENTRY I_RpcNsGetBuffer(IN=0A= RPC_STATUS RPC_ENTRY I_RpcNsSendReceive(IN PRPC_MESSAGE,OUT = RPC_BINDING_HANDLE*);=0A= void RPC_ENTRY I_RpcNsRaiseException(IN PRPC_MESSAGE,IN RPC_STATUS);=0A= RPC_STATUS RPC_ENTRY I_RpcReBindBuffer(IN PRPC_MESSAGE);=0A= -RPC_STATUS RPC_ENTRY I_NsServerBindSearch();=0A= -RPC_STATUS RPC_ENTRY I_NsClientBindSearch();=0A= -void RPC_ENTRY I_NsClientBindDone();=0A= +RPC_STATUS RPC_ENTRY I_NsServerBindSearch(void);=0A= +RPC_STATUS RPC_ENTRY I_NsClientBindSearch(void);=0A= +void RPC_ENTRY I_NsClientBindDone(void);=0A= #ifdef __cplusplus=0A= }=0A= #endif=0A= Index: include/windef.h=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /cvs/src/src/winsup/w32api/include/windef.h,v=0A= retrieving revision 1.6=0A= diff -u -b -B -p -r1.6 windef.h=0A= --- windef.h 2001/12/03 19:59:34 1.6=0A= +++ windef.h 2002/01/10 09:45:47=0A= @@ -200,9 +200,9 @@ DECLARE_HANDLE(HKL);=0A= typedef int HFILE;=0A= typedef HICON HCURSOR;=0A= typedef DWORD COLORREF;=0A= -typedef int (WINAPI *FARPROC)();=0A= -typedef int (WINAPI *NEARPROC)();=0A= -typedef int (WINAPI *PROC)();=0A= +typedef int (WINAPI *FARPROC)(void);=0A= +typedef int (WINAPI *NEARPROC)(void);=0A= +typedef int (WINAPI *PROC)(void);=0A= typedef struct tagRECT {=0A= LONG left;=0A= LONG top;=0A= ------=_NextPart_000_0064_01C199C3.E37199F0 Content-Type: text/plain; charset=us-ascii -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/ ------=_NextPart_000_0064_01C199C3.E37199F0--