Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Message-ID: <3C0D46B6.443A2E19@verizon.net>
Date: Tue, 04 Dec 2001 13:57:10 -0800
From: David Rothenberger <d DOT roth AT verizon DOT net>
X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: getsockopt broken in cygwin 1.3.6-1
References: <200112031725 DOT MAA40172 AT mail DOT acm DOT org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Kiran Prakash wrote:
> 
>  It seems that getsockopt is broken in the latest version.

I experienced the same problem with getsockopt() in the distributed
squid package.  I tracked down the problem to a little typo in
winsup/cygwin/net.cc.  I've included a patch that fixes the problem.

This is the first time I've contributed anything to cygwin.  I've read
the web pages and I think I've included everything required.  Please let
me know if I've done this incorrectly.

Dave Rothenberger
daveroth AT acm DOT org

2001-12-04  David Rothenberger  <daveroth AT acm DOT org>

	* net.cc (cygwin_getsockopt): Dereference optlen pointer when
	passing to __check_null_invalid_struct_errno.

--- net.cc-orig Tue Dec  4 13:24:17 2001
+++ net.cc      Tue Dec  4 12:54:05 2001
@@ -799,7 +799,7 @@ cygwin_getsockopt (int fd,
   int res = -1;
   const char *name = "error";
   if (!check_null_invalid_struct_errno (optlen)
-      && (!optval || !__check_null_invalid_struct_errno (optval, (unsigned) optlen))
+      && (!optval || !__check_null_invalid_struct_errno (optval, (unsigned) *optlen))
       && h)
     {
       /* For the following debug_printf */

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/