Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-Id: <200111091357.IAA29622@cs.umb.edu>
To: cygwin AT cygwin DOT com
Subject: Setup snpshot bug no skip/keep
In-Reply-To: Your message of "08 Nov 2001 23:52:42 GMT."
             <1005263562 DOT 1258 DOT ezmlm AT sources DOT redhat DOT com> 
Reply-To: rouilj AT ieee DOT org
Date: Fri, 09 Nov 2001 08:57:39 -0500
From: "John P. Rouillard" <rouilj AT cs DOT umb DOT edu>


"Gareth Pearce" <tilps AT hotmail DOT com> on Fri, 9 Nov 2001 06:44:38 +1100
said:
>Problem with no keep/skip option turning up ... happened to me last night
>... So I read some code ... tried to hunt down the problem...
>AFAICT - heh havent read much of this code yet - if the installed version is
>not one of the ones listed, in setup, you wont be able to choose keep or
>skip

That jibes with what I just saw. The setup.ini file lists 1.3.4-4 and
1.3.2-1 as the current and prev entries for cygwin. Since I have
1.3.2-2 installed, I don't get a keep option.

>in choose.cc set_action - there is a if(!pkg->installed) for skip ... i
>propose changing this so as to check if the installed version is one of the
>available ones instead.

I would suggest the following:

  if the package is installed always display keep. Doesn't matter if
  the version is available or not. It was available at some time
  and if the user want's to keep it, they should be able to.

> Then possible renameing skip to keep when pkg->installed is true.

I think you meant "if the package is not installed display skip" right?

>Will write a patch if anyone thinks this makes sense...

Yes. I think you must ALWAYS have a keep or skip option available.

				-- rouilj
John Rouillard
===============================================================================
My employers don't acknowledge my existence much less my opinions.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/