Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Tue, 6 Nov 2001 11:36:45 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH proposal] Re: Setup use on win2k - a me too ...
Message-ID: <20011106113645.B8509@redhat.com>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <OE59HpQHyD1C0Ug8cpF00003953 AT hotmail DOT com> <1005045929 DOT 5221 DOT 0 DOT camel AT lifelesswks> <3BE7CA86 DOT 2EBAC42D AT syntrex DOT com> <3BE7DFE6 DOT E8062434 AT syntrex DOT com> <1005052267 DOT 2726 DOT 19 DOT camel AT lifelesswks>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1005052267.2726.19.camel@lifelesswks>
User-Agent: Mutt/1.3.21i

On Wed, Nov 07, 2001 at 12:11:06AM +1100, Robert Collins wrote:
>On Wed, 2001-11-07 at 00:04, Pavel Tsekov wrote:
>> Btw what is done in state.cc is a bad habbit, IMO.
>
>Yes. It's C style, not CPP style. 
>
>I'll approve this if you do a patch and Changelog.
>
>NULL for everything is correct - source should be 0, as should
>net_method etc. the current code has checks for 0/NULL, but not for
>random values :].
>
>And trust_level should be deleted if not used. 

It is not a bad habit to rely on global variables being 0.  If they
aren't then something is seriously wrong with either 'ld' or the
run-time the loader.

The linux kernel developers have actually been removing explicit
initialization to zero from most of their globals and statics.  I've
been doing the same thing inside of the DLL.  It creates a smaller
executable since the variables end up being assigned to the BSS segment
which is allocated at run-time and is guaranteed to be zero.

I don't think that gratuitous changes like this are really called for
unless you can *really* show that global variables are pointing to
non-zero memory.  If that is the case then we need to figure out how
that could possibly be the case.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/