Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <3BE68FC5.C7CDF863@syntrex.com>
Date: Mon, 05 Nov 2001 14:10:29 +0100
From: Pavel Tsekov <ptsekov AT syntrex DOT com>
X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.4.2-2 i686)
X-Accept-Language: en
MIME-Version: 1.0
To: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
CC: cygwin AT cygwin DOT com
Subject: Re: [PATCH] setup.exe: removes some memory leaks from fromcwd.cc
References: <3BE2CC48 DOT 47462EC6 AT syntrex DOT com>
		<1004743324 DOT 9086 DOT 39 DOT camel AT lifelesswks>  <3BE6642E DOT 9AA62568 AT syntrex DOT com> <1004997932 DOT 1663 DOT 2 DOT camel AT lifelesswks>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Robert Collins wrote:
> 
> On Mon, 2001-11-05 at 21:04, Pavel Tsekov wrote:
> > Robert Collins wrote:
> > >
> >
> > [ snip ]
> >
> > > I haven't committed this leak - no changelog.
> >
> > Good, cause I've messed it - I'm an idiot :(. Attached is the right one.
> > And here is the Changelog entry.
> >
> 
> Thanks. Committed to HEAD.
> Feel free to find and send in such things. I've got a large chunk of
> work I hope to send a patch to cygwin-patches on tonight, which catches
> a lot of potential bugs - I've increased the compiler warning levels
> somewhat :}.
> 
> Unfortunately it's tied up with my streams work, so rather than
> committing with that in-progress (I haven't got one-of-each done yet)
> I'm going to send in a patch, which you can play with. The point of this
> is that a lot of the more mundane things you might notice should have
> been cleaned up in advance by this.

Sounds ok with me :) Btw what do you think of registering an
atexit() handler in setup so dynamically allocated global variables 
can be freed there ? This is the way I started doing the cleanup
routine at my snapshot at home. Any drawback with this approach ?

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/