Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Subject: Re: [PATCH] setup.exe: removes some memory leaks from fromcwd.cc
From: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
To: Pavel Tsekov <ptsekov AT syntrex DOT com>
Cc: cygwin AT cygwin DOT com
In-Reply-To: <3BE2CC48.47462EC6@syntrex.com>
References: <3BE2CC48 DOT 47462EC6 AT syntrex DOT com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1004743324.9086.39.camel@lifelesswks>
Mime-Version: 1.0
X-Mailer: Evolution/0.15 (Preview Release)
Date: 03 Nov 2001 10:58:39 +1100
X-OriginalArrivalTime: 03 Nov 2001 00:02:54.0847 (UTC) FILETIME=[E33CC8F0:01C163FA]

On Sat, 2001-11-03 at 03:39, Pavel Tsekov wrote:
> Hey guys ;)
> 
> It seems there are a lot of memory leaks in setup.exe :) The
> patch above fixes just two very obvious ones - however there
> seems to be a lot more of these. So I want  to know - am I blind
> or there is some black magic which frees the memroy:
> 
> For example:
> 
> I cannot see where the "package" global variable is free-ed,

I don't think it ever is, so clicking back and forward across the
setup.ini parse (occurs just before the package list shows up) should
result in continual memory use increases.

> other thing I cannot see to be free-ed is the char pointers
> from the "Info" structure which is part of the "Package" structure.

IIRC these are static pointers into the inmemory Inifile. I could easily
be wrong though.

> Perhaps there are more... If this really is a problem and I'm not
> blind, i'd like to help finding and eliminating these memory
> leaks from setup.exe.

Feel free. As usual, give me a changelog and a patch :].

I haven't committed this leak - no changelog.

Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/