Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Subject: Re: [PATCH] setup.exe & different archives for the same version of
	the app
From: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
To: Pavel Tsekov <ptsekov AT syntrex DOT com>
Cc: Ronald Landheer <ronald AT minisat DOT com>, cygwin AT cygwin DOT com,
   cygwin-patches AT cygwin DOT com
In-Reply-To: <3BE2AE80.EAF3FC24@syntrex.com>
References: <NFBBIBMBMMAMDPDHMKEBKEBACBAA DOT ronald AT minisat DOT com>
	<1004694386 DOT 6940 DOT 56 DOT camel AT lifelesswks>  <3BE2AE80 DOT EAF3FC24 AT syntrex DOT com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1004742487.9086.24.camel@lifelesswks>
Mime-Version: 1.0
X-Mailer: Evolution/0.15 (Preview Release)
Date: 03 Nov 2001 10:58:31 +1100
X-OriginalArrivalTime: 03 Nov 2001 00:02:47.0517 (UTC) FILETIME=[DEDE50D0:01C163FA]

On Sat, 2001-11-03 at 01:32, Pavel Tsekov wrote:
> Robert Collins wrote:
> > 

> > Granted. I just have no motivation to fix it, but if you have the time,
> > or someone else does, I won't object to patches that address this
> > cleanly.
>  
> See the applied patch :) Hope this will fix the problem :)

Thank you. If you could, for future patchs, have all the diffs in a
single .patch file. This makes extracting it from email and applying
earlier. (Hey, a little lziness isn't always bad).

It's customary when submitting a changelog to include the first line:

2001-11-03  Pavel Tsekov  <ptsekov AT syntrex DOT com>

> * install.cc (install_one): Checks for the existence of the tarball
> based on a set
> of well-known package extensions.
> * filemanip.h (known_file_types): Declaration of a new global variable,
> containing
> a set of known file extensions for packages handled by setup.exe.
> * choose.cc (known_file_types): A new global variable, containing a set
> of known
> file extensions for packages handled by setup.exe

These shouldn't go into choose.cc  (choose.cc is file extension blind,
it's only concerned with packages and categories).

I've moved the array into install.cc, and accordingly made it a static
variable.

This may be part of a long term solution, related to setup accurately
knowing what files exist, but for now I'm only committing it to the
categories branch. I'd like to think that once we have file-magic based
streams that any packages that have transitioned without bumping the
suffix will have dropped off due to newer version.

Thanks again,
Rob


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/