Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Mon, 24 Sep 2001 19:52:21 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [PATCH] ls & "magic" cygdrive dir (was: RE: cygdrive stuff)
Message-ID: <20010924195221.A371@redhat.com>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <NFBBLOMHALONCDMPGBLFOEFICCAA DOT info AT rlsystems DOT net> <3BAFBF02 DOT 4050809 AT likai DOT net> <100a01c1454f$bbcdbc80$0200a8c0 AT lifelesswks>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <100a01c1454f$bbcdbc80$0200a8c0@lifelesswks>
User-Agent: Mutt/1.3.21i

On Tue, Sep 25, 2001 at 09:22:08AM +1000, Robert Collins wrote:
>----- Original Message -----
>From: "Li-Kai Liu" <news AT likai DOT net>
>
>> however, files and file systems are two different concepts! fhandler
>
>Corinna has already indicated that this is the desired end direction,
>with one class hierarchy for fs's and one for files.
>
>> apparently it is not the way it is right now in cygwin. :(
>
>Exactly. However making the readdir and opendir calls use objects and
>stop being hardcoded to win32 is a good step in the right direction.
>
>> to code the way i want them to. i'll genuinely code this thing if I
>know
>> that people like my idea and so it won't end up being hated and
>discarded.
>
>It won't end up being hated and discarded :]. I strongly suggest a
>one-step-at-a-time approach though: a series of small patches that make
>specific changes to get from here to there. Biting off too much is a
>common reason for architectural changes to fail.

Yes, what he said.

With any free software project, small incremental changes are the
best way to get things done.

One other thing to point out is that if your patches involve
gratuitous changes to other parts of the code, if they are
formatted "incorrectly", if they don't include a ChangeLog
entry (not a *patch* of a ChangeLog entry), if the ChangeLog
entry is formatted incorrectly or has odd wording, then these
are also obstacles to getting a patch included.

Basically, you want to make the patch easy to read and problem-free.
Then people are apt to read them and comment on them.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/