Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Tue, 24 Jul 2001 22:30:39 +0200
From: Corinna Vinschen <cygwin AT cygwin DOT com>
To: cygwin <cygwin AT cygwin DOT com>
Subject: Re: SFTP server when / is c:\
Message-ID: <20010724223039.L1987@cygbert.vinschen.de>
Mail-Followup-To: cygwin <cygwin AT cygwin DOT com>
References: <911C684A29ACD311921800508B7293BA010A8AC2 AT cnmail>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <911C684A29ACD311921800508B7293BA010A8AC2@cnmail>; from bradshaw@staff.crosswalk.com on Tue, Jul 24, 2001 at 03:44:19PM -0400

On Tue, Jul 24, 2001 at 03:44:19PM -0400, Mark Bradshaw wrote:
> I appreciate you taking a look at this.  I didn't want to start throwing
> stuff onto the openssh developers list without having you give it the
> once-over.

A minor knit. The layout doesn't conform to the used convention.
Could you correct that?

> +	if ( strcmp(p1,"/") != 0 ) strlcat(ret, "/", len);

Better

> +	if ( strcmp(p1,"/") != 0 )
> +		strlcat(ret, "/", len);

and

> +			if ( strcmp(path, "/") ==0 ) path[0] = 0;

ditto

> +			if ( strcmp(path, "/") ==0 )
> +				path[0] = 0;

I will advocate that patch in openssh-unix-dev then.
And probably release an openssh-2.9p2-3 for Cygwin.

Thanks,
Corinna


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/