Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Tue, 26 Jun 2001 15:37:00 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: Patch: Bug: Shell fork/exec avoidance in make-3.79.1-3
Message-ID: <20010626153700.A15819@redhat.com>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <3B38CBFA DOT 97932AC8 AT agilent DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.11i
In-Reply-To: <3B38CBFA.97932AC8@agilent.com>; from earl_chew@agilent.com on Tue, Jun 26, 2001 at 10:52:58AM -0700

On Tue, Jun 26, 2001 at 10:52:58AM -0700, Earl Chew wrote:
>I've included a patch below that changes all the char[] definitions
>in job.c to char*.

Thanks for the patch.  I think that the simple solution of defining
default_shell as a 'char *' under cygwin is the correct approach to
this, though.  Looking at the rest of the code in make, it seems like
the intent is for this to be either an array or a pointer, depending on
various ifdefs.

That's what I've done to the code.  I'll be announcing a new version of
make shortly.

I very much appreciate your tracking this down.  It eases a maintainer's
load considerably when people are willing to debug problems like this
themselves.

Thanks again,
cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/