Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <BA63E2AF7155D51199CD00508BF9948F1485A9@mmcexch.mmcnet.com>
From: Jonathan Marcus <jmarcus AT mmcnet DOT com>
To: "'cygwin AT cygwin DOT com'" <cygwin AT cygwin DOT com>
Subject: Inetutils 1.3.2: Problem running ftpd server under windows 4.0
Date: Sun, 10 Jun 2001 17:28:47 -0700
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"

I have found what appears to be a bug in the ftpd server from the
inetutils 1.3.2.  I am using the server to download an embedded
processor.  The embedded client FTPs 2 files in quick succession
requesting the same TCP PORT for both.  When the server attempts the
second download, it gets an EADDRINUSE error from Windows.  It retries
the connect for 90 seconds before returning an error to the FTP client.

I don't know if the error is because the first iteration of the FTP
server didn't properly close the socket or if Windows NT is slow to
clean up the resource.  In either event, I believe that the correct
behavior would be to return the error to the client without retrying.
The code looks like this:

        while (connect(data, (struct sockaddr *)&data_dest,
            sizeof(data_dest)) < 0) {
                if (errno == EADDRINUSE && retry < swaitmax) {
                        sleep((unsigned) swaitint);
                        retry += swaitint;
                        continue;
                }
                perror_reply(425, "Can't build data connection");
                (void) fclose(file);
                data = -1;
                return (NULL);
        }

At the FTP level the interaction looks like this:

FTP Client                      FTP Server
(embedded system)               (ftpd from inetutils 1.3.2)
=====================           ===========================
PORT 10,1,120,81,4,1     --->
                        <---    200 PORT command successful.
RETR thefile             --->

                                Server attempts a connect command to
                                port 1025, which returns an EADDRINUSE
                                error.  The server then retries the
                                connect every swaitint seconds for a
                                total of swaitmax seconds.  Since the
                                connect never succeeds, the server
                                blocks for SWAITMAX (i.e. 90 seconds).

                        <---    REPLY 425 Can't build data connection:
                                Address already in use.
PORT 10,1,120,81,4,2     --->
                        <---    200 PORT command successful
RETR thefile             --->

                                Server attempts a connect command to
                                the new port number (1026) which is
                                successful.

                        <---    150 Opening BINARY mode data connection
                                for 'thefile' (203664 bytes).

                                The server starts sending data packets
                                to the client.


I would like to propose the follow change to the code.

The code which reads:


        while ((ch = getopt(argc, argv, "dlt:T:u:v")) != EOF) {
                switch (ch) {
                case 'd':
                        debug = 1;
                        break;

                case 'l':
                        logging++;      /* > 1 == extra logging */
                        break;

                case 't':
        .
        .
        .
        }

Could be changed to:


        while ((ch = getopt(argc, argv, "dlr:t:T:u:v")) != EOF) {
                switch (ch) {
                case 'd':
                        debug = 1;
                        break;

                case 'l':
                        logging++;      /* > 1 == extra logging */
                        break;

                case 'r':
                        /* Maximum time to spend retrying */
                        /* an EADDRINUSE error.            */
                        swaitmax = atoi(optarg);
                        break;

                case 't':
        .
        .
        .
        }


This would allow the server to default to the existing behavior, but let
the user specify the maximum time to spend retrying an EADDRINUSE error.
In my case, I would use the flag -r 0 to indicate that EADDRINUSE errors
would never be retried.

Thank you.

Jon Marcus
MMC Networks, Inc.

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple