Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Tue, 5 Jun 2001 22:43:08 -0400
From: Jason Tishler <Jason DOT Tishler AT dothill DOT com>
To: "Charles S. Wilson" <cwilson AT ece DOT gatech DOT edu>
Cc: cygwin AT sources DOT redhat DOT com
Subject: Re: [avail for test] readline-4.2-1
Message-ID: <20010605224308.A3095@dothill.com>
Mail-Followup-To: "Charles S. Wilson" <cwilson AT ece DOT gatech DOT edu>,
	cygwin AT sources DOT redhat DOT com
References: <20010605113203 DOT B490 AT dothill DOT com> <3B1D94C4 DOT C642BC51 AT ece DOT gatech DOT edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <3B1D94C4.C642BC51@ece.gatech.edu>; from cwilson@ece.gatech.edu on Tue, Jun 05, 2001 at 10:26:12PM -0400
Organization: Dot Hill Systems Corp.

Chuck,

On Tue, Jun 05, 2001 at 10:26:12PM -0400, Charles S. Wilson wrote:
> Jason Tishler wrote:
> > Unfortunately, due to API changes (i.e., deprecation) both PostgreSQL
> > and Python no longer build OOTB.  PostgreSQL and Python fail to link
> > because filename_completion_function() and completion_matches() are no
> > longer being exported from the readline's import library, respectively:
> 
> So, even to use the functions as included in the static lib or dll,
> you'd have to modify readline.h.  I don't think that's a good idea --
> besides, heed Chet's warning: These *will* go away (completely)
> sometime.

I saw Chet's warning too.  But, others don't seem to be taking this
warning too seriously -- see below...

> > Would you be willing to re-export these two functions (and possibly all
> > of the ones in compat.c)?  Otherwise, this is going to take some time...
> 
> Well, I believe that merely postpones the problem.

Agreed.

> Don't worry about
> the delay; take your time.  Chris has convinced me to include the old
> DLL's (e.g. cygreadline4.dll) within a new readline-4.2-2 package.  Look
> for that to come out soon.

The above is good news.

> > Devise patches, submit patches, wait for patches to be considered,
> > revise patches, submit patches, etc...
> 
> Yeah.  How do you conditionalize on library versions?  
> 
> if readline-version > 4.2, then
> #define COMPLETION_MATCHES rl_completion_matches
> else
> #define COMPLETION_MATCHES completion_matches
> endif
> 
> ????

I found the following patch on the pgsql-patches list:

    http://postgresql.readysetnet.com/mhonarc/pgsql-patches/2001-04/msg00049.html

It seemed exactly for what I was looking.  Unfortunately, it was
rejected in favor for what appears (at least to me) to be the "ostrich"
approach. :,)

I will post to the python-dev and pgsql-patches lists, attempting to
solicit the best approach with which to go forward.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: 732.264.8770 x235
Dot Hill Systems Corp.               Fax:   732.264.8798
82 Bethany Road, Suite 7             Email: Jason DOT Tishler AT dothill DOT com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple