Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <3B0B6AF3.818DBC@certum.pl>
Date: Wed, 23 May 2001 09:46:59 +0200
From: Jacek Trzcinski <jacek AT certum DOT pl>
Reply-To: jacek AT certum DOT pl
X-Mailer: Mozilla 4.7 [en] (WinNT; U)
X-Accept-Language: en,pdf
MIME-Version: 1.0
To: Corinna Vinschen <cygwin AT cygwin DOT com>
Subject: Re: Serial programming patch
References: <3B0A5B48 DOT D8508D38 AT certum DOT pl> <20010522215504 DOT J10118 AT cygbert DOT vinschen DOT de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi Corinna,
I see it will be cost a little pain.
What concerns Your 3-rd remark (code not conforming GNU standard) is it
enough to
transform my sources utilizing indent.exe ?. If so, what switches should
I use ?
I have two remarks I forgot mention about in my previous e-mail.

To read input queue there should be use constant FIONREAD (information
taken from different sources) but cygwin occupy it for socket software
!(it is macro). Constant TIOCINQ I have
taken from linux where it is equal FIONREAD(FIONREAD is not occupied in
linux like in cygwin).
Next matter concerns device name convention. In cygwin one may use
/dev/com1 or /dev/ttyS1
and so on. (what for is utilizing /dev/comx I do not know - it is not
portable to linux).
I think also that number of devices should start from 0 not from 1
(/dev/ttyS0 and so on) like in linux because again it is not portable.
What is Your opinion ?
Jacek


Corinna Vinschen wrote:
> 
> Thanks for your work. Unfortunately, we can't use it for three
> reasons:
> 
> - The patch is too long to use it without you signing a copyright
>   assignment form. Look on http://cygwin.com/contrib.html for details.
> 
> - A ChangeLog entry is missing. Please add a plain ChangeLog entry to
>   your posting like the ones you can see in the Cygwin ChangeLog file.
> 
> - Your code is not conforming to the GNU coding standard.
>   Look on http://www.gnu.org/prep/standards_toc.html for details
>   (or just compare with the other code in Cygwin).
> 
> Then you're adding a member to fhandler_serial to check for the OS
> that way:
> 
>         osVersion=GetVersion();
>         [...]
>         if(!(osVersion&0x80000000))
> 
> while Cygwin already has a way to check that without the need to
> add a member:
> 
>         if (os_being_run == winNT)  // or win95, win98, winME
> 
> Btw, there's a special mailing list cygwin-patches AT cygwin DOT com to send
> and discuss patches to Cygwin. If you want to contribute to the project
> it would have some advantages to subscribe to that list and to the list
> cygwin-developers AT cygwin DOT com as well.
> 
> I hope I didn't discourage you too much. Each contributor (and Chris and
> I began as contributors, too) had to go through this.
> 
> Corinna
> 
> On Tue, May 22, 2001 at 02:27:52PM +0200, Jacek Trzcinski wrote:
> > Hi !,
> > Here is my patch to serial device. I implemented ioctl function which
> > makes possible
> > [...]
> 
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin AT cygwin DOT com
> Red Hat, Inc.
> 
> --
> Want to unsubscribe from this list?
> Check out: http://cygwin.com/ml/#unsubscribe-simple

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple