Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <001301c0e326$b9eaa940$38810142@pavilion>
From: "J. J. Farrell" <jjf AT bcs DOT org DOT uk>
To: <cygwin AT sources DOT redhat DOT com>
Subject: Re: Serial programming patch
Date: Tue, 22 May 2001 18:21:37 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="x-user-defined"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4522.1200
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200

From: Jacek Trzcinski <jacek AT certum DOT pl>
>
> Here is my patch to serial device. I implemented ioctl function which
> makes possible
> to get modem lines state (CTS,DSR,RI,CD) and set(get) modem control
> lines (RTS and DTR)
>
> ...
>
> +
> +/* ioctl: POSIX  */
> +int
> +fhandler_serial::ioctl (unsigned int cmd,void * buffer)

Just a very minor nit-pick: it might reduce future confusion if the word
"POSIX" were removed from that comment. POSIX doesn't specify an ioctl()
function or any means to access the modem control signals on serial lines.




--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple