Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Wed, 11 Apr 2001 10:30:13 +0200
From: Corinna Vinschen <cygwin AT cygwin DOT com>
To: cygwin <cygwin AT cygwin DOT com>
Cc: Enoch Wu <enochw AT scn DOT org>
Subject: Re: Patch portnumber for sSMTP
Message-ID: <20010411103013.G956@cygbert.vinschen.de>
Mail-Followup-To: cygwin <cygwin AT cygwin DOT com>, Enoch Wu <enochw AT scn DOT org>
References: <20010410185327 DOT A4021635 AT MELON>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010410185327.A4021635@MELON>; from enochw@scn.org on Tue, Apr 10, 2001 at 06:53:27PM -0700

On Tue, Apr 10, 2001 at 06:53:27PM -0700, Enoch Wu wrote:
> Hi Corinna & all,
> 
> I am "uploading" the patch to add something like:
> 
> MailHub=mail.domain.com:2525 
> 
> in /etc/ssmtp/ssmtp.conf
> 
> root:id AT domain DOT com:mail.domain.com:2525
> 
> in /etc/ssmtp/revaliases

Thanks for your effort!

However, I have a minor nit:

In function parseConfig():

> +              if ((r = strtok (NULL, "= \t\n:")) != NULL) PortNum = atoi(strdup(r));

I think the strdup isn't needed here. May I suggest asking for PortNum=0
afterwards and resetting it to PORTNUMBER, if so? Just to be  a bit
fault-tolerant.

And there's a small error:

> +		  log_event (LOG_INFO,
> +			     "via SMTP Port Number=\"%s\".\n", PortNum);

You're using "%s" for a integer variable here. Shouldn't that be "%d"?
The same in getReverseAliases():

> +		      log_event (LOG_INFO,
> +			         "via SMTP Port Number=\"%s\".\n", PortNum);

Could you please resubmit the patch? I will create a new ssmtp release
then. Are you willing to send your patch to the ssmtp maintainer
(Matt Ryan <matt AT banana DOT org DOT uk>) as well?

Thank you,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple